Skip to content

[Modules] Azure Cosmos DB SQL Container Indexing policy#1578

Merged
AlexanderSehr merged 8 commits intomainfrom
users/fblix/cosmosIndexingPolicy
Dec 2, 2022
Merged

[Modules] Azure Cosmos DB SQL Container Indexing policy#1578
AlexanderSehr merged 8 commits intomainfrom
users/fblix/cosmosIndexingPolicy

Conversation

@fblix
Copy link
Copy Markdown
Contributor

@fblix fblix commented Jun 23, 2022 •
edited
Loading

Description

Thank you for your contribution !

This PR adds the ability to configure an indexingPolicy for sqldatabase containers for an Azure Cosmos DB.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

DocumentDB: DatabaseAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@fblix fblix changed the title Users/fblix/cosmos indexing policy Azure Cosmos DB SQL Container Indexing policy Jun 23, 2022
@AlexanderSehr AlexanderSehr changed the title Azure Cosmos DB SQL Container Indexing policy [Modules] Azure Cosmos DB SQL Container Indexing policy Jun 23, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jun 23, 2022
@itpropro
Copy link
Copy Markdown
Contributor

itpropro commented Jun 23, 2022

Indexing policy does not work with some specific capabilities (e.g. serverless) and with all database types (e.g. gremlin). We should wait until the PR #1566 is done and then add extensive tests for the different CosmosDB APIs and capabilities.

@AlexanderSehr
Copy link
Copy Markdown
Contributor

AlexanderSehr commented Jul 6, 2022

Indexing policy does not work with some specific capabilities (e.g. serverless) and with all database types (e.g. gremlin). We should wait until the PR #1566 is done and then add extensive tests for the different CosmosDB APIs and capabilities.

Correcting, it is now #1638

@fblix fblix requested a review from a team as a code owner December 1, 2022 09:39
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 1, 2022 •
edited
Loading

Test Results

    1 files      1 suites   2m 7s ⏱️
278 tests 274 ✔️ 4 💤 0 ❌
308 runs  301 ✔️ 7 💤 0 ❌

Results for commit ffe9bed.

♻️ This comment has been updated with latest results.

Felix Borst added 2 commits December 1, 2022 10:54
*added indexing policy to gremlin
e256899 
*added tests for sql and gremlin
fixed readme
ffe9bed
@fblix
Copy link
Copy Markdown
Contributor Author

fblix commented Dec 1, 2022

updated with new dependency approach and ready for merge.

@fblix fblix closed this Dec 1, 2022
@fblix fblix reopened this Dec 1, 2022
@fblix fblix requested a review from AlexanderSehr December 1, 2022 11:31
@AlexanderSehr AlexanderSehr merged commit 19705d4 into main Dec 2, 2022
@AlexanderSehr AlexanderSehr deleted the users/fblix/cosmosIndexingPolicy branch December 2, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@fblix fblix

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fblix @itpropro @AlexanderSehr @eriqua