Skip to content

[Modules] Added CosmosDB Gremlin API & updated mongodb to current version#1638

Merged
AlexanderSehr merged 8 commits intomainfrom
users/itpropro/gremlin
Jul 7, 2022
Merged

[Modules] Added CosmosDB Gremlin API & updated mongodb to current version#1638
AlexanderSehr merged 8 commits intomainfrom
users/itpropro/gremlin

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Jul 6, 2022

Description

Based on a PR by @itpropro #1566

  • Added mongodb version 4.2 and updated default

  • Added capabilities array for DocumentDB

  • Added gremlin databases as part of DocumentDB

  • Added gremlin graphs as part of gremlin databases

  • Added documentation

  • TODO: Fix deployment error Requests for API gremlin are not supported for this account

Pipeline references

Pipeline
DocumentDB: DatabaseAccounts

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

itpropro and others added 2 commits July 6, 2022 07:42
* feat(document-db):  Added CosmosDB Gremlin API and updated mongodb to current version

* docs(graphs):  Updated readme.md

* feat(document-db):  Added backupPolicy, updated docs

* Update arm/Microsoft.DocumentDB/databaseAccounts/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* feat(gremlin-databases):  Added tests and small bugfixes

* feat(gremlin):  Updated tests, pipeline, parameters

* refactor(test):  Changed .parameters to .test

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner July 6, 2022 05:47
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jul 6, 2022
@AlexanderSehr AlexanderSehr marked this pull request as draft July 6, 2022 07:34
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 6, 2022

Unit Test Results

    1 files  ±    0      1 suites  ±0   46s ⏱️ +31s
255 tests +214  252 ✔️ +212  3 💤 +2  0 ±0 
258 runs  +217  255 ✔️ +215  3 💤 +2  0 ±0 

Results for commit 896a3e4. ± Comparison against base commit 6b94237.

This pull request removes 41 and adds 255 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/diskEncryptionSets] used resource type [diskEncryptionSets] should use one of the recent API version(s). Currently using [2021-04-01]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/diskEncryptionSets] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/diskEncryptionSets] used resource type [vaults/accessPolicies] should use one of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] Location output should be returned for resources that use it
…
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/gremlinDatabases/graphs] used resource type [databaseAccounts/gremlinDatabases/graphs] should use one of the recent API version(s). Currently using [2022-02-15-preview]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/gremlinDatabases] used resource type [databaseAccounts/gremlinDatabases/graphs] should use one of the recent API version(s). Currently using [2022-02-15-preview]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/gremlinDatabases] used resource type [databaseAccounts/gremlinDatabases] should use one of the recent API version(s). Currently using [2022-02-15-preview]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/mongodbDatabases/collections] used resource type [databaseAccounts/mongodbDatabases/collections] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/mongodbDatabases] used resource type [databaseAccounts/mongodbDatabases/collections] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/mongodbDatabases] used resource type [databaseAccounts/mongodbDatabases] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/sqlDatabases/containers] used resource type [databaseAccounts/sqlDatabases/containers] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/sqlDatabases] used resource type [databaseAccounts/sqlDatabases/containers] should use one of the recent API version(s). Currently using [2021-07-01-preview]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts/sqlDatabases] used resource type [databaseAccounts/sqlDatabases] should use one of the recent API version(s). Currently using [2021-06-15]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DocumentDB/databaseAccounts] used resource type [databaseAccounts/gremlinDatabases/graphs] should use one of the recent API version(s). Currently using [2022-02-15-preview]
…
This pull request removes 1 skipped test and adds 3 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DocumentDB/databaseAccounts/gremlinDatabases/graphs] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DocumentDB/databaseAccounts/mongodbDatabases/collections] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DocumentDB/databaseAccounts/sqlDatabases/containers] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)

@AlexanderSehr AlexanderSehr marked this pull request as ready for review July 6, 2022 13:11
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) July 6, 2022 13:12
@AlexanderSehr AlexanderSehr merged commit 86678e9 into main Jul 7, 2022
@AlexanderSehr AlexanderSehr deleted the users/itpropro/gremlin branch July 7, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants