Skip to content

[Modules] Redis cache module#1582

Merged
AlexanderSehr merged 9 commits intoAzure:users/itpropro/redisfrom
itpropro:feature/redis
Jul 4, 2022
Merged

[Modules] Redis cache module#1582
AlexanderSehr merged 9 commits intoAzure:users/itpropro/redisfrom
itpropro:feature/redis

Conversation

@itpropro
Copy link
Copy Markdown
Contributor

Description

Added redis cache module with the following ResourceModule provided defaults:

  • Telemetry
  • Resource locks
  • Diagnostics settings
  • RBAC

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels Jun 23, 2022
@eriqua eriqua changed the title [Module] Redis cache module [Modules] Redis cache module Jun 23, 2022
@AlexanderSehr AlexanderSehr changed the base branch from main to users/itpropro/redis June 27, 2022 13:03
@itpropro
Copy link
Copy Markdown
Contributor Author

itpropro commented Jul 3, 2022

Added all the missing parts @MrMCake

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@itpropro, thanks for that. I'll migrate the PR later today :)

@AlexanderSehr AlexanderSehr merged commit 6f1c940 into Azure:users/itpropro/redis Jul 4, 2022
@AlexanderSehr AlexanderSehr mentioned this pull request Jul 4, 2022
7 tasks
AlexanderSehr added a commit that referenced this pull request Jul 11, 2022
* [MAJOR/BREAKING] Renamed `arm` to `modules` (#1498)

* Renamed `arm` to `modules` (#1498)

* Updated readme

* Updated readme

* Minor update

* Added trigger to arm convertion test

* Adjusted pester

* Fixed in readme function

* Re-added deleted template

* Fixed pipeline reference

* Fixed pipeline reference

* Fixed pipeline title

* Fixed another typo

* Fixed another typo

* Fixed casing

* Fixed service fabric pipeline reference

* First batch of changes

* Further renames

* Updated parameter fetch function

* Updated docs

* Further rename

* First commit

* [Modules] Redis cache module (#1582)

* feat(webpubsub):  Added Web PubSub module

* feat(webpubsub):  Updated folders, added tests, updated readme

* feat(webpubsub):  Added nested rbac

* feat(redis-cache):  Added Redis cache module

* feat(redis-cache):  Cleaned up branch history

* fix(redis): Updated diagnostics name

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* feat(redis): ✨  Added tests, pipelines and secure defaults

* refactor(test):  Changed .parameters to .test

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Moved folder

* Updated pipeline

* Update to latest

* Updated readm

* Updated template

* Updated readme

* pdated default

* Updated output

* Formatted roles

* Update modules/Microsoft.Cache/redis/deploy.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Update modules/Microsoft.Cache/redis/deploy.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Renamed param

* Added private endpoints

* Switched to basic sku

* Adjusted family property

* Refactored family parameter

* Update modules/Microsoft.Cache/redis/deploy.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Updated desc

* Updated docs

* Updated rbac roles

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <marstor@hotmail.com>
Co-authored-by: Jan-Henrik Damaschke <jdamaschke@visorian.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@itpropro itpropro deleted the feature/redis branch August 19, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants