Skip to content

[MAJOR/BREAKING] Renamed arm to modules#1498

Merged
MariusStorhaug merged 19 commits intoAzure:issue/1127from
MariusStorhaug:main
Jun 25, 2022
Merged

[MAJOR/BREAKING] Renamed arm to modules#1498
MariusStorhaug merged 19 commits intoAzure:issue/1127from
MariusStorhaug:main

Conversation

@MariusStorhaug
Copy link
Copy Markdown
Contributor

Description

Rename the arm folder to modules, updating all referenced paths.

Pipeline references

Pipeline
Coming!

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug added documentation Improvements or additions to documentation [prio] high importance of the issue: high priority [cat] pipelines category: pipelines [cat] modules category: modules [cat] testing category: testing [cat] publishing category: publishing [cat] github category: GitHub [cat] azure devops category: Azure DevOps labels Jun 6, 2022
@MariusStorhaug MariusStorhaug self-assigned this Jun 6, 2022
@MariusStorhaug MariusStorhaug marked this pull request as ready for review June 7, 2022 10:56
@MariusStorhaug MariusStorhaug requested review from AlexanderSehr, ahmadabdalla, eriqua and rahalan and removed request for eriqua June 7, 2022 10:56
@eriqua eriqua marked this pull request as draft June 7, 2022 11:40
@eriqua eriqua removed the [prio] high importance of the issue: high priority label Jun 8, 2022
@AlexanderSehr AlexanderSehr linked an issue Jun 23, 2022 that may be closed by this pull request
@MariusStorhaug MariusStorhaug changed the base branch from main to issue/1127 June 25, 2022 21:20
@MariusStorhaug MariusStorhaug linked an issue Jun 25, 2022 that may be closed by this pull request
@MariusStorhaug MariusStorhaug marked this pull request as ready for review June 25, 2022 22:36
@MariusStorhaug
Copy link
Copy Markdown
Contributor Author

Merging to the issue/1127 branch and creating a new PR to bring it to main.

@MariusStorhaug MariusStorhaug merged commit 8f79958 into Azure:issue/1127 Jun 25, 2022
MariusStorhaug pushed a commit that referenced this pull request Jun 27, 2022
* [MAJOR/BREAKING] Renamed `arm` to `modules` (#1498)

Co-authored-by: MrMCake <asehr@hotmail.de>
AlexanderSehr added a commit that referenced this pull request Jun 29, 2022
* [MAJOR/BREAKING] Renamed `arm` to `modules` (#1498)

* Renamed `arm` to `modules` (#1498)

* Updated readme

* Updated readme

* Minor update

* Added trigger to arm convertion test

* Adjusted pester

* Fixed in readme function

* Re-added deleted template

* Fixed pipeline reference

* Fixed pipeline reference

* Fixed pipeline title

* Fixed another typo

* Fixed another typo

* Fixed casing

* Fixed service fabric pipeline reference

* First batch of changes

* Further renames

* Updated parameter fetch function

* Updated docs

* Further rename

* Resolved conflicts

* Resolved conflict

* Adjusted verbosity

* Renamed [.deploymentTests] to [.test]

* Renamed folders

* Adjusted verbosity

* Fixed format

* Cleanup param files

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <marstor@hotmail.com>
AlexanderSehr added a commit that referenced this pull request Jul 11, 2022
* [MAJOR/BREAKING] Renamed `arm` to `modules` (#1498)

* Renamed `arm` to `modules` (#1498)

* Updated readme

* Updated readme

* Minor update

* Added trigger to arm convertion test

* Adjusted pester

* Fixed in readme function

* Re-added deleted template

* Fixed pipeline reference

* Fixed pipeline reference

* Fixed pipeline title

* Fixed another typo

* Fixed another typo

* Fixed casing

* Fixed service fabric pipeline reference

* First batch of changes

* Further renames

* Updated parameter fetch function

* Updated docs

* Further rename

* First commit

* [Modules] Redis cache module (#1582)

* feat(webpubsub):  Added Web PubSub module

* feat(webpubsub):  Updated folders, added tests, updated readme

* feat(webpubsub):  Added nested rbac

* feat(redis-cache):  Added Redis cache module

* feat(redis-cache):  Cleaned up branch history

* fix(redis): Updated diagnostics name

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* feat(redis): ✨  Added tests, pipelines and secure defaults

* refactor(test):  Changed .parameters to .test

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Moved folder

* Updated pipeline

* Update to latest

* Updated readm

* Updated template

* Updated readme

* pdated default

* Updated output

* Formatted roles

* Update modules/Microsoft.Cache/redis/deploy.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Update modules/Microsoft.Cache/redis/deploy.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Renamed param

* Added private endpoints

* Switched to basic sku

* Adjusted family property

* Refactored family parameter

* Update modules/Microsoft.Cache/redis/deploy.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Updated desc

* Updated docs

* Updated rbac roles

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <marstor@hotmail.com>
Co-authored-by: Jan-Henrik Damaschke <jdamaschke@visorian.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] modules category: modules [cat] pipelines category: pipelines [cat] publishing category: publishing [cat] testing category: testing documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report]: Fix trigger for ServiceFabric/Clusters Upcoming BREAKING change: Renaming folder arm to modules

3 participants