Skip to content

[CI Environment] [MAJOR/BREAKING] Renamed arm to modules#1599

Merged
MariusStorhaug merged 18 commits intomainfrom
issue/1127
Jun 27, 2022
Merged

[CI Environment] [MAJOR/BREAKING] Renamed arm to modules#1599
MariusStorhaug merged 18 commits intomainfrom
issue/1127

Conversation

@MariusStorhaug
Copy link
Copy Markdown
Contributor

@MariusStorhaug MariusStorhaug commented Jun 25, 2022

Description

Rename the arm folder to modules, updating all referenced paths.

Pipeline references

GitHub Workflow Azure DevOps Pipeline
 AAD: DomainServices           Build Status
 AnalysisServices: Servers   Build Status
 ApiManagement: Service   Build Status
 AppConfiguration: ConfigurationStores   Build Status
 Authorization: Locks       Build Status
 Authorization: PolicyAssignments   Build Status
 Authorization: PolicyDefinitions   Build Status
 Authorization: PolicyExemptions   Build Status
 Authorization: PolicySetDefinitions   Build Status
 Authorization: RoleAssignments   Build Status
 Authorization: RoleDefinitions   Build Status
 Automation: AutomationAccounts   Build Status
 Batch: BatchAccounts       Build Status
 CognitiveServices: Accounts   Build Status
 Compute: AvailabilitySets   Build Status
 Compute: DiskEncryptionSets   Build Status
 Compute: Disks   Build Status
 Compute: Galleries   Build Status
 Compute: Images   Build Status
 Compute: ProximityPlacementGroups   Build Status
 Compute: VirtualMachines   Build Status
 Compute: VirtualMachineScaleSets   Build Status
 Consumption: Budgets       Build Status
 ContainerInstance: ContainerGroups   Build Status
 ContainerRegistry: Registries   Build Status
 ContainerService: ManagedClusters   Build Status
 Databricks: Workspaces   Build Status
 DataFactory: Factories   Build Status
 DataProtection: BackupVaults   Build Status
 DesktopVirtualization: ApplicationGroups   Build Status
 DesktopVirtualization: HostPools   Build Status
 DesktopVirtualization: Scalingplans   Build Status
 DesktopVirtualization: Workspaces   Build Status
 DocumentDB: DatabaseAccounts   Build Status
 EventGrid: System Topics   Build Status
 EventGrid: Topics   Build Status
 EventHub: Namespaces       Build Status
 HealthBot: HealthBots   Build Status
 Insights: ActionGroups   Build Status
 Insights: ActivityLogAlerts   Build Status
 Insights: Components       Build Status
 Insights: DiagnosticSettings   Build Status
 Insights: MetricAlerts   Build Status
 Insights: PrivateLinkScopes   Build Status
 Insights: ScheduledQueryRules   Build Status
 KeyVault: Vaults   Build Status
 KubernetesConfiguration: Extensions   Build Status
 KubernetesConfiguration: FluxConfigurations   Build Status
 Logic: Workflows   Build Status
 MachineLearningServices: Workspaces   Build Status
 ManagedIdentity: UserAssignedIdentities   Build Status
 ManagedServices: RegistrationDefinitions   Build Status
 Management: ManagementGroups   Build Status
 NetApp: NetAppAccounts   Build Status
 Network: ApplicationGateways   Build Status
 Network: ApplicationSecurityGroups   Build Status
 Network: AzureFirewalls   Build Status    
 Network: BastionHosts   Build Status      
 Network: Connections       Build Status      
 Network: DdosProtectionPlans   Build Status
 Network: ExpressRouteCircuits   Build Status
 Network: FirewallPolicies   Build Status  
 Network: Frontdoors         Build Status
 Network: IpGroups   Build Status
 Network: LoadBalancers   Build Status    
 Network: LocalNetworkGateways   Build Status
 Network: NatGateways       Build Status      
 Network: NetworkInterfaces   Build Status
 Network: NetworkSecurityGroups   Build Status
 Network: NetworkWatchers   Build Status  
 Network: PrivateDnsZones   Build Status  
 Network: PrivateEndpoints   Build Status  
 Network: PublicIpAddresses   Build Status
 Network: PublicIpPrefixes   Build Status  
 Network: RouteTables       Build Status      
 Network: TrafficManagerProfiles   Build Status
 Network: VirtualHubs       Build Status
 Network: VirtualNetworkGateways   Build Status
 Network: VirtualNetworks   Build Status  
 Network: VirtualWans       Build Status      
 Network: VPN Sites   Build Status
 Network: VPNGateways       Build Status
 OperationalInsights: Workspaces   Build Status
 OperationsManagement: Solutions   Build Status
 RecoveryServices: Vaults   Build Status
 Resources: DeploymentScripts   Build Status
 Resources: ResourceGroups   Build Status
 Resources: Tags   Build Status
 Security: AzureSecurityCenter   Build Status
 Service Fabric: Clusters   Build Status
 ServiceBus: Namespaces   Build Status
 Sql: ManagedInstances   Build Status
 Sql: Servers   Build Status
 Storage: StorageAccounts   Build Status
 Synapse: PrivateLinkHubs   Build Status
 VirtualMachineImages: ImageTemplates   Build Status
 Web: Connections   Build Status
 Web: HostingEnvironments   Build Status
 Web: Serverfarms   Build Status
 Web: Sites   Build Status
 Web: StaticSites   Build Status

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

* Renamed `arm` to `modules` (#1498)
@AlexanderSehr AlexanderSehr changed the title [MAJOR/BREAKING] Renamed arm to modules [CI Environment] [MAJOR/BREAKING] Renamed arm to modules Jun 26, 2022
@AlexanderSehr AlexanderSehr added documentation Improvements or additions to documentation [prio] high importance of the issue: high priority [cat] testing category: testing [cat] github category: GitHub [cat] azure devops category: Azure DevOps labels Jun 26, 2022
@MariusStorhaug MariusStorhaug requested a review from eriqua June 26, 2022 06:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 26, 2022

Unit Test Results

  1 files  ±  0    1 suites  ±0   13s ⏱️ -20s
47 tests  - 79  46 ✔️  - 79  1 💤 ±0  0 ±0 
48 runs   - 80  47 ✔️  - 80  1 💤 ±0  0 ±0 

Results for commit c5e4457. ± Comparison against base commit 27b1952.

This pull request removes 126 and adds 47 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.NetApp/netAppAccounts/capacityPools/volumes] used resource type [netAppAccounts/capacityPools/volumes] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.NetApp/netAppAccounts/capacityPools/volumes] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.NetApp/netAppAccounts/capacityPools] used resource type [netAppAccounts/capacityPools/volumes] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.NetApp/netAppAccounts/capacityPools] used resource type [netAppAccounts/capacityPools] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.NetApp/netAppAccounts/capacityPools] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.NetApp/netAppAccounts] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.NetApp/netAppAccounts] used resource type [netAppAccounts/capacityPools/volumes] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.NetApp/netAppAccounts] used resource type [netAppAccounts/capacityPools] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.NetApp/netAppAccounts] used resource type [netAppAccounts] should use one of the recent API version(s). Currently using [2021-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.NetApp/netAppAccounts] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
…
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KubernetesConfiguration/fluxConfigurations] used resource type [fluxConfigurations] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KubernetesConfiguration/fluxConfigurations] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KubernetesConfiguration/fluxConfigurations] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KubernetesConfiguration/fluxConfigurations] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KubernetesConfiguration/fluxConfigurations] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KubernetesConfiguration/fluxConfigurations] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KubernetesConfiguration/fluxConfigurations] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KubernetesConfiguration/fluxConfigurations] Location output should be returned for resources that use it
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KubernetesConfiguration/fluxConfigurations] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KubernetesConfiguration/fluxConfigurations] Parameter names should be camel-cased (no dashes or underscores and must start with lower-case letter)
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.NetApp/netAppAccounts/capacityPools/volumes] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/modules/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KubernetesConfiguration/fluxConfigurations] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr linked an issue Jun 26, 2022 that may be closed by this pull request
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) June 27, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] testing category: testing documentation Improvements or additions to documentation [prio] high importance of the issue: high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upcoming BREAKING change: Renaming folder arm to modules

2 participants