[Modules] Updated Network/VPNGateways to new dependency approach by AlexanderSehr · Pull Request #1833 · Azure/ResourceModules

AlexanderSehr · 2022-08-30T19:57:29Z

Description

Updated Network/VPNGateways to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Update to documentation

github-actions · 2022-08-30T20:01:08Z

Unit Test Results

    1 files ±  0     1 suites ±0 1m 0s ⏱️ +32s
125 tests +78 120 ✔️ +73 5 💤 +5 0 ❌ ±0
135 runs +88 129 ✔️ +82 6 💤 +6 0 ❌ ±0

Results for commit 14a166a. ± Comparison against base commit 0f158c0.

This pull request removes 47 and adds 125 tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationGateways] used resource type [applicationGateways] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationGateways] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationGateways] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationGateways] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationGateways] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
…

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways/connections] used resource type [vpnGateways/vpnConnections] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways/natRules] used resource type [vpnGateways/natRules] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [vpnGateways/natRules] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [vpnGateways/vpnConnections] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [vpnGateways] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/connections] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/connections] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/connections] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/vpnGateways/connections] All required parameters in template file (deploy.json) should exist in parameters files
…

♻️ This comment has been updated with latest results.

modules/Microsoft.Network/vpnGateways/.test/common/deploy.test.bicep

….bicep

modules/Microsoft.Network/vpnGateways/.test/min/deploy.test.bicep

github-actions · 2022-11-24T08:57:20Z

Test Results

    1 files ±    0     1 suites ±0 1m 14s ⏱️ - 1m 42s
125 tests - 304 120 ✔️ - 297 5 💤 - 7 0 ❌ ±0
135 runs - 308 129 ✔️ - 300 6 💤 - 8 0 ❌ ±0

Results for commit 8e1572f. ± Comparison against base commit 0f68fdd.

modules/Microsoft.Network/vpnGateways/.test/common/deploy.test.bicep

eriqua

🆗

[Modules] Updated Network/VPNGateways to new dependency approach

e6805a2

AlexanderSehr self-assigned this Aug 30, 2022

AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Aug 30, 2022

AlexanderSehr mentioned this pull request Aug 30, 2022

[Feature Request]: Re-work modules to new dependency approach #1791

Closed

AlexanderSehr added 3 commits September 1, 2022 11:35

Merge branch 'main' into users/alsehr/1791_Network_VPNGateways

8592072

Update to latest

e82c8a0

Merge branch 'main' into users/alsehr/1791_Network_VPNGateways

37a3930

AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request

Update Network/vpnGateways to new dependencies approach #1956

Closed

AlexanderSehr added 6 commits September 5, 2022 20:26

Updated docs

14a166a

Updated folder default to common.

e4ed801

Update to latest

99835fc

Update to latest

2de4a80

Update to latest

de49c20

Update to latest

5305ad3

AlexanderSehr commented Sep 19, 2022

View reviewed changes

modules/Microsoft.Network/vpnGateways/.test/common/deploy.test.bicep Outdated Show resolved Hide resolved

Update modules/Microsoft.Network/vpnGateways/.test/common/deploy.test…

ce0f3c5

….bicep

AlexanderSehr commented Sep 19, 2022

View reviewed changes

modules/Microsoft.Network/vpnGateways/.test/min/deploy.test.bicep Outdated Show resolved Hide resolved

AlexanderSehr and others added 2 commits September 19, 2022 19:54

Update modules/Microsoft.Network/vpnGateways/.test/min/deploy.test.bicep

d6de4a8

Update to latest

0791b19

eriqua added the [prio] high importance of the issue: high priority label Sep 25, 2022

AlexanderSehr added 8 commits October 5, 2022 20:25

Update to latest

a673644

Update to latest

f5f9960

Update to latest

e64bf2e

Update to latest

bc857b3

minor fix

5a9ecf9

Update to latest

97c7852

another test without routing info

8d1e6cf

Merge branch 'main' into users/alsehr/1791_Network_VPNGateways

4d2f266

AlexanderSehr added 6 commits November 18, 2022 12:19

Small IP adjustments

b9f3936

latest test

8b7c388

Merge branch 'main' into users/alsehr/1791_Network_VPNGateways

9cb0cb2

Update to latest

397e0ca

Working example

31ac114

Fallback to working example

8e1572f

AlexanderSehr marked this pull request as ready for review November 24, 2022 10:13

AlexanderSehr requested a review from a team as a code owner November 24, 2022 10:13

AlexanderSehr enabled auto-merge (squash) November 24, 2022 10:13

eriqua reviewed Nov 24, 2022

View reviewed changes

modules/Microsoft.Network/vpnGateways/.test/common/deploy.test.bicep Outdated Show resolved Hide resolved

Updated dependency

d3b7339

eriqua approved these changes Nov 25, 2022

View reviewed changes

AlexanderSehr merged commit 736684f into main Nov 25, 2022

AlexanderSehr deleted the users/alsehr/1791_Network_VPNGateways branch November 25, 2022 08:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Modules] Updated Network/VPNGateways to new dependency approach#1833

[Modules] Updated Network/VPNGateways to new dependency approach#1833
AlexanderSehr merged 28 commits intomainfrom
users/alsehr/1791_Network_VPNGateways

AlexanderSehr commented Aug 30, 2022

Uh oh!

github-actions bot commented Aug 30, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 24, 2022

Uh oh!

Uh oh!

eriqua left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

AlexanderSehr commented Aug 30, 2022

Description

Pipeline references

Type of Change

Uh oh!

github-actions bot commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 24, 2022

Test Results

Uh oh!

Uh oh!

eriqua left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Aug 30, 2022 •

edited

Loading