Skip to content

Users/ahmad/vnet peering#199

Merged
AlexanderSehr merged 59 commits intoAzure:mainfrom
ahmadabdalla:users/ahmad/vnetPeering
Oct 17, 2021
Merged

Users/ahmad/vnet peering#199
AlexanderSehr merged 59 commits intoAzure:mainfrom
ahmadabdalla:users/ahmad/vnetPeering

Conversation

@ahmadabdalla
Copy link
Copy Markdown
Contributor

@ahmadabdalla ahmadabdalla commented Oct 17, 2021

Change

  • Updated the virtualNetworkPeering bicep to be simple and deploy one vnet peering resource.
  • Added parameters for the virtual network peering properties. Set default to certain types (common).
  • Updated the API version.
  • Updated documentation.
  • Moved original bicep to the constructs folder.
  • Removed complex logic for the peering name and set in the parameter.

Code has been tested in the fork:
Network: Virtualnetworks Virtualnetworkpeerings

image

Type of Change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr merged commit 1e4e395 into Azure:main Oct 17, 2021
@ahmadabdalla ahmadabdalla deleted the users/ahmad/vnetPeering branch October 17, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants