Merged
Conversation
ahmadabdalla
added a commit
that referenced
this pull request
Oct 14, 2021
* added Az Policy and RBAC Modules * updated user identity module * catered for scenario where retryLimit is set to 1 * added (ge) instead of (gt) for catch * updated based on comments * updated lock scope * updated test error for readme * updated readme * fixed readme * updated readme with check mark * updated lock resource * Clean up commit * Modified pipelines to point to bicep file instead * updated read me * supressed parameter location validation * added workaround * added readme details * completed RBAC Assignment * remove check for variable name (_) * updated policy read me * updated policy * updated parameters * updated readme * updated policy length * updated policy definitions pipeline * added exemption and set definition pipelines * Users/ahmadabdalla/ms authorization (#2) * added policy exemption * Users/ahmadabdalla/ms auth comments (#3) * updated policy definitions module * added current version of roles to constructs * updated parameter files to point to test subscription * updated based on feedback * updated to test principal ID
ahmadabdalla
added a commit
that referenced
this pull request
Oct 19, 2021
* added Az Policy and RBAC Modules * updated user identity module * catered for scenario where retryLimit is set to 1 * added (ge) instead of (gt) for catch * updated based on comments * updated lock scope * updated test error for readme * updated readme * fixed readme * updated readme with check mark * updated lock resource * Clean up commit * Modified pipelines to point to bicep file instead * updated read me * supressed parameter location validation * added workaround * added readme details * completed RBAC Assignment * remove check for variable name (_) * updated policy read me * updated policy * updated parameters * updated readme * updated policy length * updated policy definitions pipeline * added exemption and set definition pipelines * Users/ahmadabdalla/ms authorization (#2) * added policy exemption * Users/ahmadabdalla/ms auth comments (#3) * updated policy definitions module * added current version of roles to constructs * updated parameter files to point to test subscription * updated based on feedback * updated to test principal ID * Updated VNET Peering Template * updated output from testing * Updated virtual network peering bicep module * restored parameters to iacs
ahmadabdalla
pushed a commit
that referenced
this pull request
Nov 8, 2021
* restructure vnet child resources * update pipeline * update readme * update parameter name * fix * fix #2 * shorten deployment name * fix path * fix path * fix wrong entry * remove unneeded files * update name * update ourputs
ahmadabdalla
pushed a commit
that referenced
this pull request
May 28, 2022
Add func to have different behavior on PR and dev branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Feel free to remove this sample text
Type of Change
Please delete options that are not relevant.
Checklist