Skip to content

Users/rahalan/add vnet child resources#428

Merged
rahalan merged 16 commits intomainfrom
users/rahalan/AddVnetChildResources
Nov 8, 2021
Merged

Users/rahalan/add vnet child resources#428
rahalan merged 16 commits intomainfrom
users/rahalan/AddVnetChildResources

Conversation

@rahalan
Copy link
Copy Markdown
Contributor

@rahalan rahalan commented Nov 6, 2021

Change

Change vNet module structure to have vnet peering as a child resource

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@rahalan rahalan linked an issue Nov 8, 2021 that may be closed by this pull request
@rahalan rahalan added this to the v 0.3 milestone Nov 8, 2021
@rahalan rahalan enabled auto-merge (squash) November 8, 2021 10:11
Copy link
Copy Markdown
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments seem to be fixed. Approved.

@rahalan rahalan merged commit a50f534 into main Nov 8, 2021
@MariusStorhaug MariusStorhaug deleted the users/rahalan/AddVnetChildResources branch November 8, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update virtual networks to new child-resource structure Feature Request

3 participants