Skip to content

Users/rahalan/add vnet child resources #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahalan merged 16 commits into from
Nov 8, 2021
Merged

Users/rahalan/add vnet child resources #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ba26ce8
restructure vnet child resources
rahalan Nov 6, 2021
a62a9b3
update pipeline
rahalan Nov 6, 2021
45da2e7
Merge remote-tracking branch 'origin/main' into users/rahalan/AddVnet…
rahalan Nov 6, 2021
cfcccc8
update readme
rahalan Nov 6, 2021
db52259
update parameter name
rahalan Nov 6, 2021
d33fb28
fix
rahalan Nov 6, 2021
9ab70d2
fix #2
rahalan Nov 6, 2021
8965500
shorten deployment name
rahalan Nov 6, 2021
1958165
fix path
rahalan Nov 6, 2021
c93fb5d
fix path
rahalan Nov 6, 2021
3fa53d1
fix wrong entry
rahalan Nov 6, 2021
3f60e76
remove unneeded files
rahalan Nov 7, 2021
93ee69b
update name
rahalan Nov 7, 2021
1235778
update ourputs
rahalan Nov 7, 2021
4f675a8
Merge remote-tracking branch 'origin/main' into users/rahalan/AddVnet…
rahalan Nov 8, 2021
14e6e81
remove yml file
rahalan Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
216 changes: 0 additions & 216 deletions .github/workflows/ms.network.virtualnetworks.virtualnetworkpeerings.yml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/ms.network.virtualnetworks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
strategy:
fail-fast: false
matrix:
parameterFilePaths: ['parameters.json']
parameterFilePaths: ['parameters.json', 'vnetPeering.parameters.json']
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
strategy:
fail-fast: false
matrix:
parameterFilePaths: ['parameters.json']
parameterFilePaths: ['parameters.json', 'vnetPeering.parameters.json']
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion arm/Microsoft.Network/virtualNetworks/.parameters/parameters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
"contentVersion": "1.0.0.0",
"parameters": {
"vnetName": {
"name": {
"value": "sxx-az-vnet-x-001"
},
"vnetAddressPrefixes": {
Expand Down
141 changes: 141 additions & 0 deletions arm/Microsoft.Network/virtualNetworks/.parameters/vnetPeering.parameters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
{
"$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
"contentVersion": "1.0.0.0",
"parameters": {
"name": {
"value": "sxx-az-vnet-x-001"
},
"vnetAddressPrefixes": {
"value": [
"10.0.0.0/16"
]
},
"subnets": {
"value": [
{
"name": "GatewaySubnet",
"addressPrefix": "10.0.255.0/24"
},
{
"name": "sxx-az-subnet-x-001",
"addressPrefix": "10.0.0.0/24",
"networkSecurityGroupName": "",
"routeTableName": "",
"serviceEndpoints": [
{
"service": "Microsoft.EventHub"
},
{
"service": "Microsoft.Sql"
},
{
"service": "Microsoft.Storage"
},
{
"service": "Microsoft.KeyVault"
}
],
"delegations": []
},
{
"name": "sxx-az-subnet-x-002",
"addressPrefix": "10.0.1.0/24",
"networkSecurityGroupName": "",
"routeTableName": "",
"serviceEndpoints": [
{
"service": "Microsoft.EventHub"
},
{
"service": "Microsoft.Sql"
},
{
"service": "Microsoft.Storage"
},
{
"service": "Microsoft.KeyVault"
}
],
"delegations": []
},
{
"name": "sxx-az-subnet-x-003",
"addressPrefix": "10.0.2.0/24",
"networkSecurityGroupName": "",
"routeTableName": "",
"serviceEndpoints": [],
"delegations": [
{
"name": "sqlMiDel",
"properties": {
"serviceName": "Microsoft.Sql/managedInstances"
}
}
]
},
{
"name": "sxx-az-subnet-x-004",
"addressPrefix": "10.0.3.0/24",
"networkSecurityGroupName": "",
"routeTableName": "",
"serviceEndpoints": [],
"delegations": [
{
"name": "netappDel",
"properties": {
"serviceName": "Microsoft.Netapp/volumes"
}
}
]
},
{
"name": "AzureFirewallSubnet",
"addressPrefix": "10.0.4.0/24",
"networkSecurityGroupName": "",
"routeTableName": "",
"serviceEndpoints": [],
"delegations": []
},
{
"name": "AzureBastionSubnet",
"addressPrefix": "10.0.5.0/24",
"networkSecurityGroupName": "",
"routeTableName": "",
"serviceEndpoints": [],
"delegations": []
},
{
"name": "sxx-az-subnet-x-005",
"addressPrefix": "10.0.6.0/24",
"networkSecurityGroupName": "",
"routeTableName": "",
"serviceEndpoints": [],
"delegations": [],
"privateEndpointNetworkPolicies": "Disabled", // This property must be set to disabled for subnets that contain private endpoints. It confirms that NSGs rules will not apply to private endpoints (currently not supported). Default Value when not specified is "Enabled".
"privateLinkServiceNetworkPolicies": "Enabled"
}
]
},
"virtualNetworkPeerings": {
"value": [
{
"remoteVirtualNetworkId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-sxx-az-vnet-x-peer01",
"allowForwardedTraffic": true,
"allowGatewayTransit": false,
"allowVirtualNetworkAccess": true,
"useRemoteGateways": false
}
]
},
"roleAssignments": {
"value": [
{
"roleDefinitionIdOrName": "Reader",
"principalIds": [
"cf33fea8-b30f-424f-ab73-c48d99e0b222"
]
}
]
}
}
}
Loading