Skip to content

[Modules] Updated OperationsManagement Solutions to new dependency approach#2013

Merged
AlexanderSehr merged 14 commits intomainfrom
users/alsehr/1791_OperationsManagement_solutions
Nov 4, 2022
Merged

[Modules] Updated OperationsManagement Solutions to new dependency approach#2013
AlexanderSehr merged 14 commits intomainfrom
users/alsehr/1791_OperationsManagement_solutions

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

Description

  • Updated OperationsManagement Solutions to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
OperationsManagement: Solutions

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 10, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 10, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 10, 2022

Unit Test Results

  1 files  ±  0    1 suites  ±0   46s ⏱️ ±0s
50 tests  -   5  49 ✔️  -   5  1 💤 ±0  0 ±0 
70 runs   - 12  67 ✔️  - 11  3 💤  - 1  0 ±0 

Results for commit 36de0b4. ± Comparison against base commit f1f0552.

This pull request removes 55 and adds 50 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [accounts] should use one of the recent API version(s). Currently using [2021-10-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All required parameters in template file (deploy.json) should exist in parameters files
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.OperationsManagement/solutions] used resource type [solutions] should use one of the recent API version(s). Currently using [2015-11-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationsManagement/solutions] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationsManagement/solutions] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationsManagement/solutions] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationsManagement/solutions] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationsManagement/solutions] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationsManagement/solutions] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationsManagement/solutions] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationsManagement/solutions] Location output should be returned for resources that use it
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationsManagement/solutions] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.CognitiveServices/accounts] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.OperationsManagement/solutions] *parameters.json files in the .test folder should be valid json

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 24, 2022 14:55
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner October 24, 2022 14:55
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 29, 2022 08:27
@AlexanderSehr AlexanderSehr requested a review from eriqua November 4, 2022 15:22
AlexanderSehr and others added 2 commits November 4, 2022 17:45
…endencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…loy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
AlexanderSehr and others added 4 commits November 4, 2022 17:45
…oy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…ndencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…ependencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…eploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 0dade62 into main Nov 4, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_OperationsManagement_solutions branch November 4, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update OperationsManagement/solutions to new dependencies approach

3 participants