Added more options to Microsoft.ContainerInstances/containergroups module#2175
Merged
AlexanderSehr merged 41 commits intomainfrom Dec 23, 2022
Merged
Conversation
…users/fblix_jpeasier/1526-multiContainer
…/github.com/Azure/ResourceModules into users/fblix_jpeasier/1867-container-options
…users/fblix_jpeasier/1867-container-options
…/github.com/Azure/ResourceModules into users/fblix_jpeasier/1867-container-options
…/github.com/Azure/ResourceModules into users/fblix_jpeasier/1867-container-options
added 2 commits
October 6, 2022 16:32
eriqua
reviewed
Oct 6, 2022
Contributor
eriqua
left a comment
eriqua
left a comment
There was a problem hiding this comment.
Hi @fblix and thanks a lot for this contribution. We're currently converting all modules to a new self-contained dependencies approach, for which we're going to deploy dependencies as part of module tests and also converting tests to use .bicep templates instead of .json parameters. For this module we already have a PR open #1874 which will cause merge conflicts to this PR once merged. For this reason I'm moving this PR to draft, I will prioritize the review of PR #1874 and let you know once merged.
modules/Microsoft.ContainerInstance/containerGroups/.test/private/dependencies.bicep
Outdated
Show resolved
Hide resolved
…ate/dependencies.bicep
modules/Microsoft.ContainerInstance/containerGroups/.test/private/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.ContainerInstance/containerGroups/deploy.bicep
Outdated
Show resolved
Hide resolved
…ate/deploy.test.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
AlexanderSehr
approved these changes
Dec 23, 2022
AlexanderSehr
deleted the
users/fblix_jpeasier/1867-container-options
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1867
Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist