[Modules] OPT1 - Update nested_roleAssignment to comply with prefer-unquoted-property-names linter rule#2187
Closed
[Modules] OPT1 - Update nested_roleAssignment to comply with prefer-unquoted-property-names linter rule#2187
nested_roleAssignment to comply with prefer-unquoted-property-names linter rule#2187Conversation
eriqua
added
enhancement
| } | ||
| $resArm += "`"{0}`": `"[subscriptionResourceId('Microsoft.Authorization/roleDefinitions','{1}')]`"," -f $role.Name, $role.Id | ||
| } | ||
| $resBicep = $resBicepTop + $resBicepQuote |
Contributor
There was a problem hiding this comment.
I'd almost prefer an alphabetical order to a 'visual' split. But I don't want to decide this :D
Contributor
Author
There was a problem hiding this comment.
Fair point. I've created PR #2200 with the alternative approach to be discussed
Contributor
There was a problem hiding this comment.
I guess automation is king? :D
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
eriqua
changed the title
nested_roleAssignment to comply with prefer-unquoted-property-names linter rulenested_roleAssignment to comply with prefer-unquoted-property-names linter rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
nested_roleAssignmentto comply withprefer-unquoted-property-nameslinter rule (Remove quotes from role definition names not containing spaces)nested_roleAssignmentwith role definition list fetched by the Get-RoleAssignmentsList.ps1 utilityprefer-unquoted-property-nameslinter rule ignore from bicep.configPipeline references
Type of Change
Please delete options that are not relevant.
Checklist