Skip to content

[Modules] OPT2 - Update nested_roleAssignment to comply with prefer-unquoted-property-names linter rule#2200

Merged
eriqua merged 26 commits intomainfrom
users/erikag/rbac-quotes-opt2
Nov 4, 2022
Merged

[Modules] OPT2 - Update nested_roleAssignment to comply with prefer-unquoted-property-names linter rule#2200
eriqua merged 26 commits intomainfrom
users/erikag/rbac-quotes-opt2

Conversation

@eriqua
Copy link
Copy Markdown
Contributor

@eriqua eriqua commented Oct 11, 2022

Description

  • Update nested_roleAssignment to comply with prefer-unquoted-property-names linter rule (Remove quotes from role definition names not containing spaces)
  • Update nested_roleAssignment with role definition list fetched by the Get-RoleAssignmentsList.ps1 utility
  • Remove prefer-unquoted-property-names linter rule ignore from bicep.config
  • Update Get-RoleAssignmentList.ps1 utility
  • Add Update-NestedRoleAssignmentList.ps1 utility
  • Wiki update

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua marked this pull request as ready for review November 3, 2022 15:18
@eriqua eriqua requested a review from a team as a code owner November 3, 2022 15:18
@eriqua eriqua enabled auto-merge (squash) November 4, 2022 16:20
@eriqua eriqua merged commit 42be8c6 into main Nov 4, 2022
@eriqua eriqua deleted the users/erikag/rbac-quotes-opt2 branch November 4, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] utilities category: utilities enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Handle new Bicep linter warning prefer-unquoted-property-names

2 participants