Update NetworkWatcher to new child-resource structure by MariusStorhaug · Pull Request #432 · Azure/ResourceModules

MariusStorhaug · 2021-11-07T18:50:04Z

Change

Updated NetworkWatcher resource and child-resources to new child resource structure
Updated VM dependency to include VM extension for network watch to be used for Connection Monitors.

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update (Wiki)

Checklist

I'm sure there are no other open Pull Requests for the same update/change
My corresponding pipelines / checks run clean and green without any errors or warnings
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (readme)
I did format my code

github-actions · 2021-11-07T22:57:23Z

Unit Test Results

  1 files ±0 1 suites ±0 17s ⏱️ +3s
  5 tests ±0 5 ✔️ ±0   0 💤 ±0 0 ❌ ±0
37 runs +1 5 ✔️ ±0 32 💤 +1 0 ❌ ±0

Results for commit 637405f. ± Comparison against base commit 30e4b44.

This pull request removes 5 and adds 5 tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.NetApp/netAppAccounts] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.NetApp/netAppAccounts] used resource type [netAppAccounts/capacityPools/volumes] should use on of the recent API version(s). Currently using [2021-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.NetApp/netAppAccounts] used resource type [netAppAccounts/capacityPools] should use on of the recent API version(s). Currently using [2021-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.NetApp/netAppAccounts] used resource type [netAppAccounts] should use on of the recent API version(s). Currently using [2021-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.NetApp/netAppAccounts] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.Network/networkWatchers] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.Network/networkWatchers] used resource type [networkWatchers/connectionMonitors] should use on of the recent API version(s). Currently using [2021-03-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.Network/networkWatchers] used resource type [networkWatchers/flowLogs] should use on of the recent API version(s). Currently using [2021-03-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.Network/networkWatchers] used resource type [networkWatchers] should use on of the recent API version(s). Currently using [2021-02-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.Network/networkWatchers] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]

♻️ This comment has been updated with latest results.

arm/Microsoft.Network/networkWatchers/.parameters/min.parameters.json

arm/Microsoft.Network/networkWatchers/connectionMonitors/readme.md

…/github.com/Azure/ResourceModules into users/mast/MS.Network/networkWatchers_child

arm/Microsoft.Network/networkWatchers/connectionMonitors/readme.md

Marius added 2 commits November 7, 2021 19:47

Moved flowLogs to be child of NetworkWatcher

e24c7ac

Remove child resource workflow

617b474

MariusStorhaug linked an issue Nov 7, 2021 that may be closed by this pull request

Update Network watcher to new child-resource structure Feature Request #342

Closed

MariusStorhaug self-assigned this Nov 7, 2021

MariusStorhaug added [cat] modules category: modules enhancement New feature or request [prio] high importance of the issue: high priority labels Nov 7, 2021

MariusStorhaug added this to the v 0.3 milestone Nov 7, 2021

Marius added 2 commits November 7, 2021 23:48

Restructure networkWatcher, flowlogs and connectionmonitors

05f22e8

Add required params

ddda112

Marius and others added 19 commits November 8, 2021 00:03

fix parameters

b4819b6

test new params

fad1b32

test with default parameters

c9807ed

fix minimum parameters to go to a different location

fc36925

rmeoved location from full params

8514b46

update readme

8ed2c18

Comment change to readme to trigger ci

feb9715

Added location to flowlogs

0d29013

Setting enabled to true

989ccc8

correcting enablement of flowAnalytics

c1daff6

reset workflow file

370270e

Test Connection Monitors

e11cb97

Test again

0496bb2

Need NetworkWatcher extension on VM for networkWatcher/ConnectionMonitor

be81506

Cleanup for new connection monitor

ab2acbc

Fix mapping from nw deploy file

d0ed83c

Test Deployment

d213069

Test with AzureVM as endpoint type

637405f

Uncomment branch and path condition on trigger(on)

2af086b

MariusStorhaug marked this pull request as ready for review November 8, 2021 13:07

MariusStorhaug changed the title ~~[WIP] Update NetworkWatcher to new child-resource structure~~ Update NetworkWatcher to new child-resource structure Nov 8, 2021

MariusStorhaug enabled auto-merge (squash) November 8, 2021 13:09

simonbMS reviewed Nov 8, 2021

View reviewed changes

arm/Microsoft.Network/networkWatchers/.parameters/min.parameters.json Show resolved Hide resolved

This was linked to issues Nov 8, 2021

Update Microsoft.Network/networkWatcher to new child-resource structure Feature Request #414

Closed

Module: NetworkWatcher merge NSGFlowLogs #234

Closed

simonbMS reviewed Nov 8, 2021

View reviewed changes

arm/Microsoft.Network/networkWatchers/connectionMonitors/readme.md Outdated Show resolved Hide resolved

Simone Bertaccini and others added 4 commits November 8, 2021 15:05

Remove blank

3d887c0

Removed leftover TODOs

b43237d

Merge branch 'users/mast/MS.Network/networkWatchers_child' of https:/…

a85fdc5

…/github.com/Azure/ResourceModules into users/mast/MS.Network/networkWatchers_child

removed space

295901a

simonbMS approved these changes Nov 8, 2021

View reviewed changes

arm/Microsoft.Network/networkWatchers/connectionMonitors/readme.md Outdated Show resolved Hide resolved

MariusStorhaug merged commit 58a16ce into main Nov 8, 2021

MariusStorhaug deleted the users/mast/MS.Network/networkWatchers_child branch November 8, 2021 14:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update NetworkWatcher to new child-resource structure#432

Update NetworkWatcher to new child-resource structure#432
MariusStorhaug merged 27 commits intomainfrom
users/mast/MS.Network/networkWatchers_child

MariusStorhaug commented Nov 7, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Nov 7, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MariusStorhaug commented Nov 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change

Type of Change

Checklist

Uh oh!

github-actions bot commented Nov 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MariusStorhaug commented Nov 7, 2021 •

edited

Loading

github-actions bot commented Nov 7, 2021 •

edited

Loading