-
Notifications
You must be signed in to change notification settings - Fork 437
Update NetworkWatcher to new child-resource structure #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MariusStorhaug
merged 27 commits into
main
from
users/mast/MS.Network/networkWatchers_child
Nov 8, 2021
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e24c7ac
Moved flowLogs to be child of NetworkWatcher
617b474
Remove child resource workflow
05f22e8
Restructure networkWatcher, flowlogs and connectionmonitors
ddda112
Add required params
b4819b6
fix parameters
fad1b32
test new params
c9807ed
test with default parameters
fc36925
fix minimum parameters to go to a different location
8514b46
rmeoved location from full params
8ed2c18
update readme
feb9715
Comment change to readme to trigger ci
0d29013
Added location to flowlogs
989ccc8
Setting enabled to true
c1daff6
correcting enablement of flowAnalytics
370270e
reset workflow file
e11cb97
Test Connection Monitors
0496bb2
Test again
be81506
Need NetworkWatcher extension on VM for networkWatcher/ConnectionMonitor
ab2acbc
Cleanup for new connection monitor
d0ed83c
Fix mapping from nw deploy file
d213069
Test Deployment
MariusStorhaug 637405f
Test with AzureVM as endpoint type
2af086b
Uncomment branch and path condition on trigger(on)
3d887c0
Remove blank
b43237d
Removed leftover TODOs
a85fdc5
Merge branch 'users/mast/MS.Network/networkWatchers_child' of https:/…
295901a
removed space
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
216 changes: 0 additions & 216 deletions
216
.github/workflows/ms.network.networkwatcherflowlogs.yml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 0 additions & 36 deletions
36
arm/Microsoft.Network/networkWatcherFlowLogs/.parameters/parameters.json
This file was deleted.
Oops, something went wrong.
9 changes: 9 additions & 0 deletions
9
arm/Microsoft.Network/networkWatchers/.parameters/min.parameters.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "parameters": { | ||
| "location": { | ||
| "value": "northeurope" | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.