Skip to content

Virtual Hub : Create module#910

Merged
AlexanderSehr merged 133 commits intoAzure:users/alsehr/908_virtualHubfrom
AlexanderSehr:main
Jan 22, 2022
Merged

Virtual Hub : Create module#910
AlexanderSehr merged 133 commits intoAzure:users/alsehr/908_virtualHubfrom
AlexanderSehr:main

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

Change

  • Added module Virtual Hub
  • Added child modules route table & connection

Note: The module needs a virtual WAN deployed. As we don't have one constantly - this module will not work in CARML until we implemented a new approach for dependencies (similar to the Gateway Connection module)

Pipeline reference
Network: Virtual Hubs

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label Jan 20, 2022
@AlexanderSehr AlexanderSehr self-assigned this Jan 20, 2022
@AlexanderSehr AlexanderSehr added this to the v 0.4 milestone Jan 20, 2022
@AlexanderSehr AlexanderSehr linked an issue Jan 20, 2022 that may be closed by this pull request
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) January 20, 2022 17:12
@AlexanderSehr AlexanderSehr changed the base branch from main to users/alsehr/908_virtualHub January 22, 2022 15:07
@AlexanderSehr AlexanderSehr merged commit 8e9e454 into Azure:users/alsehr/908_virtualHub Jan 22, 2022
AlexanderSehr added a commit that referenced this pull request Feb 1, 2022
* Virtual Hub : Create module (#910)

* Recovered original state + moved token replacement

* Update to latest

* Fixed ref

* Updated join path

* Minor fix

* Updated pipe

* Replaced task to use connection

* Update to latest

* Update to latest

* Minor update

* Update to latest

* Update to latest

* Update to latest

* Merged upstream

* Accounted for empty var

* Updated path handling

* Minor update

* Removed min parameter file from VM to avoid conflict

* Push updated Readme file(s)

* Updated ref

* Push updated Readme file(s)

* Updated removal ref

* Generated remaning pipelines

* Added also the Azure DevOps pipeline generation script & template

* Update to latest

* Update to latest

* Updating condition

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Cleanup

* Force failed deployment

* Update to latest

* Update to latest

* Regenerated pipelines

* Minor linter update

* Update to latest

* Removed deliberate error

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* initial version

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* platform + wiki sync ADO pipelines

* updated naming

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Minor docs fix

* Minor docs fix

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Renamed gh variables

* Added space

* Updated parameters

* Cleanup

* Update to latest

* Removed owner

* Added readme descr

* Update to latest

* Update to latest

* Back latest draft

* Added route table & extended tests

* Added pipelines

* Updated docs

* Updated param

Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
Co-authored-by: Msanzdelrio <masanzde@microsoft.com>

* Added dedicated vnet deployment to vHub

* Update arm/Microsoft.Network/virtualHubs/.parameters/parameters.json

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Update utilities/pipelines/dependencies/Microsoft.Network/virtualNetworks/parameters/7.virtualHubConnection.parameters.json

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Update arm/Microsoft.Network/virtualHubs/.parameters/min.parameters.json

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Update arm/Microsoft.Network/virtualHubs/.parameters/parameters.json

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Added missing version files

* Updated pipelines to latest

* Update arm/Microsoft.Network/virtualHubs/deploy.bicep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update arm/Microsoft.Network/virtualHubs/readme.md

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Updated to token handling

Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
Co-authored-by: Msanzdelrio <masanzde@microsoft.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Virtual Hub module

2 participants