Skip to content

Virtual Hub : Create module#921

Merged
AlexanderSehr merged 14 commits intomainfrom
users/alsehr/908_virtualHub
Feb 1, 2022
Merged

Virtual Hub : Create module#921
AlexanderSehr merged 14 commits intomainfrom
users/alsehr/908_virtualHub

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Jan 22, 2022

Change

  • Added module Virtual Hub
  • Added child modules route table & connection

Note: The module needs a virtual WAN deployed. As we don't have one constantly - this module will not work in CARML until we implemented a new approach for dependencies (similar to the Gateway Connection module)

Pipeline reference
Network: Virtual Hubs

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr @Msanzdelrio
Virtual Hub : Create module (#910)
8e9e454 
* Recovered original state + moved token replacement

* Update to latest

* Fixed ref

* Updated join path

* Minor fix

* Updated pipe

* Replaced task to use connection

* Update to latest

* Update to latest

* Minor update

* Update to latest

* Update to latest

* Update to latest

* Merged upstream

* Accounted for empty var

* Updated path handling

* Minor update

* Removed min parameter file from VM to avoid conflict

* Push updated Readme file(s)

* Updated ref

* Push updated Readme file(s)

* Updated removal ref

* Generated remaning pipelines

* Added also the Azure DevOps pipeline generation script & template

* Update to latest

* Update to latest

* Updating condition

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Cleanup

* Force failed deployment

* Update to latest

* Update to latest

* Regenerated pipelines

* Minor linter update

* Update to latest

* Removed deliberate error

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* initial version

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* platform + wiki sync ADO pipelines

* updated naming

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Minor docs fix

* Minor docs fix

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Renamed gh variables

* Added space

* Updated parameters

* Cleanup

* Update to latest

* Removed owner

* Added readme descr

* Update to latest

* Update to latest

* Back latest draft

* Added route table & extended tests

* Added pipelines

* Updated docs

* Updated param

Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
Co-authored-by: Msanzdelrio <masanzde@microsoft.com>
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label Jan 22, 2022
@AlexanderSehr AlexanderSehr added this to the v 0.4 milestone Jan 22, 2022
@AlexanderSehr AlexanderSehr self-assigned this Jan 22, 2022
@AlexanderSehr AlexanderSehr linked an issue Jan 22, 2022 that may be closed by this pull request
Implement Virtual Hub module #908
Closed
eriqua
eriqua reviewed Jan 27, 2022
View reviewed changes
eriqua
eriqua reviewed Jan 27, 2022
View reviewed changes
eriqua
eriqua reviewed Jan 27, 2022
View reviewed changes
AlexanderSehr and others added 4 commits January 28, 2022 01:00
@AlexanderSehr @eriqua
Update arm/Microsoft.Network/virtualHubs/.parameters/parameters.json
7e5986a 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update utilities/pipelines/dependencies/Microsoft.Network/virtualNetw…
cb9200c 
…orks/parameters/7.virtualHubConnection.parameters.json

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update arm/Microsoft.Network/virtualHubs/.parameters/min.parameters.json
145bda3 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update arm/Microsoft.Network/virtualHubs/.parameters/parameters.json
1ae5f3e 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
rahalan
rahalan previously approved these changes Feb 1, 2022
View reviewed changes
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) February 1, 2022 11:39
MariusStorhaug
MariusStorhaug suggested changes Feb 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No diagsettings,lock or RBAC?

AlexanderSehr and others added 2 commits February 1, 2022 22:50
@AlexanderSehr
Update arm/Microsoft.Network/virtualHubs/deploy.bicep
350f3f8 
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Network/virtualHubs/readme.md
0b0e064 
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) February 1, 2022 22:52
MariusStorhaug
MariusStorhaug approved these changes Feb 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@AlexanderSehr AlexanderSehr merged commit 57002fd into main Feb 1, 2022
@MariusStorhaug MariusStorhaug deleted the users/alsehr/908_virtualHub branch February 1, 2022 22:58
@AlexanderSehr AlexanderSehr linked an issue Mar 2, 2022 that may be closed by this pull request
vWAN: Move modules out of vWAN #982
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua left review comments

@rahalan rahalan rahalan left review comments

+1 more reviewer

@MariusStorhaug MariusStorhaug MariusStorhaug approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules

Projects

None yet

Milestone

v 0.4

Development

Successfully merging this pull request may close these issues.

vWAN: Move modules out of vWAN Implement Virtual Hub module

4 participants

@AlexanderSehr @MariusStorhaug @eriqua @rahalan