Skip to content

Bug fix for ConvertTo-ARMTemplate#944

Merged
MariusStorhaug merged 3 commits intomainfrom
users/mast/conversionfix
Jan 28, 2022
Merged

Bug fix for ConvertTo-ARMTemplate#944
MariusStorhaug merged 3 commits intomainfrom
users/mast/conversionfix

Conversation

@MariusStorhaug
Copy link
Copy Markdown
Contributor

Change

  • Only clean up deploy.json when bicep exists before the conversion.
  • Don't attempt to replace workflow or pipeline files if they do not exist. (i.e folders for ado or gh is removed)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug added bug Something isn't working [cat] pipelines category: pipelines [cat] modules category: modules [cat] github category: GitHub [cat] azure devops category: Azure DevOps labels Jan 28, 2022
@MariusStorhaug MariusStorhaug added this to the v 0.4 milestone Jan 28, 2022
@MariusStorhaug MariusStorhaug requested a review from eriqua January 28, 2022 17:35
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) January 28, 2022 17:35
@MariusStorhaug MariusStorhaug self-assigned this Jan 28, 2022
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@MariusStorhaug MariusStorhaug merged commit 58aec33 into main Jan 28, 2022
@AlexanderSehr AlexanderSehr deleted the users/mast/conversionfix branch January 30, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working [cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] modules category: modules [cat] pipelines category: pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conversion script - Failing if either .github or .azurepipelines are deleted Conversion to ARM - removes valid json templates if ran twice

2 participants