Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

chore: add go mod support#1077

Closed
andyliuliming wants to merge 1 commit intoAzure:masterfrom
andyliuliming:andliu/add_go_mod_support
Closed

chore: add go mod support#1077
andyliuliming wants to merge 1 commit intoAzure:masterfrom
andyliuliming:andliu/add_go_mod_support

Conversation

@andyliuliming
Copy link
Member

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@andyliuliming
Copy link
Member Author

/assign @jackfrancis

@mboersma mboersma changed the title add the go mod support to aks engine. chore: add go mod support to aks engine. Apr 17, 2019
@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #1077 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1077   +/-   ##
=======================================
  Coverage   74.33%   74.33%           
=======================================
  Files         131      131           
  Lines       18259    18259           
=======================================
  Hits        13573    13573           
  Misses       3905     3905           
  Partials      781      781

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Apr 17, 2019

The commit message needs to use conventional commit style to make sure that squash commit shows up in release notes.

Also no need for the "in aks engine" part in the commit message since this PR is in the aks-engine project.

/hold

@CecileRobertMichon
Copy link
Contributor

@andyliuliming can you please update the PR description?

@andyliuliming andyliuliming force-pushed the andliu/add_go_mod_support branch from c0ed005 to ebac07f Compare April 17, 2019 16:26
@andyliuliming andyliuliming changed the title chore: add go mod support to aks engine. chore: add go mod support Apr 17, 2019
@CecileRobertMichon
Copy link
Contributor

/hold cancel

@CecileRobertMichon
Copy link
Contributor

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mboersma
Copy link
Member

Your comment in #1078 suggests this change won't work on its own when the time comes to vendor aks-engine into another codebase.

Could we just update sirupsen/logrus with dep and not introduce go modules?

@andyliuliming
Copy link
Member Author

Hi @jackfrancis @mboersma , could you please help merge this PR if no other comments? so I can do the according change in ACSRP repo. thanks.

@stale
Copy link

stale bot commented May 25, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 25, 2019
@stale stale bot closed this Jun 1, 2019
@mboersma mboersma reopened this Jun 4, 2019
@stale stale bot removed the stale label Jun 4, 2019
@acs-bot
Copy link

acs-bot commented Jun 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: andyliuliming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma mentioned this pull request Jun 4, 2019
4 tasks
@mboersma mboersma closed this Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants