Conversation
|
/assign @jackfrancis |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1077 +/- ##
=======================================
Coverage 74.33% 74.33%
=======================================
Files 131 131
Lines 18259 18259
=======================================
Hits 13573 13573
Misses 3905 3905
Partials 781 781 |
|
The commit message needs to use conventional commit style to make sure that squash commit shows up in release notes. Also no need for the "in aks engine" part in the commit message since this PR is in the aks-engine project. /hold |
|
@andyliuliming can you please update the PR description? |
c0ed005 to
ebac07f
Compare
|
/hold cancel |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Your comment in #1078 suggests this change won't work on its own when the time comes to vendor aks-engine into another codebase. Could we just update |
|
Hi @jackfrancis @mboersma , could you please help merge this PR if no other comments? so I can do the according change in ACSRP repo. thanks. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: andyliuliming The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reason for Change:
Issue Fixed:
Requirements:
Notes: