This repository was archived by the owner on Oct 24, 2023. It is now read-only.
Closed
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
=======================================
Coverage 75.56% 75.56%
=======================================
Files 128 128
Lines 18039 18039
=======================================
Hits 13632 13632
Misses 3618 3618
Partials 789 789 |
Member
Author
|
There's no particular urgency to this, so let's put it on the back burner again until there is an actual need. I'll keep the branch around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adds go module support for dependency vendoring, but doesn't remove
depstuff yet.All credit goes to @andyliuliming, I just polished this up.
Issue Fixed:
Replaces #1077
Requirements:
Notes:
@andyliuliming is this important for AKS vendoring, or just something to future-proof us?