Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

chore: add go mod support#1435

Closed
mboersma wants to merge 2 commits intoAzure:masterfrom
mboersma:go-go-modules
Closed

chore: add go mod support#1435
mboersma wants to merge 2 commits intoAzure:masterfrom
mboersma:go-go-modules

Conversation

@mboersma
Copy link
Member

@mboersma mboersma commented Jun 4, 2019

Reason for Change:
Adds go module support for dependency vendoring, but doesn't remove dep stuff yet.

All credit goes to @andyliuliming, I just polished this up.

Issue Fixed:
Replaces #1077

Requirements:

Notes:
@andyliuliming is this important for AKS vendoring, or just something to future-proof us?

@mboersma mboersma requested a review from andyliuliming June 4, 2019 20:20
@acs-bot
Copy link

acs-bot commented Jun 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #1435 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1435   +/-   ##
=======================================
  Coverage   75.56%   75.56%           
=======================================
  Files         128      128           
  Lines       18039    18039           
=======================================
  Hits        13632    13632           
  Misses       3618     3618           
  Partials      789      789

@mboersma
Copy link
Member Author

There's no particular urgency to this, so let's put it on the back burner again until there is an actual need. I'll keep the branch around.

@mboersma mboersma closed this Jun 10, 2019
@mboersma mboersma deleted the go-go-modules branch November 22, 2019 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants