Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

fix: use cordon/drain timeout for pod eviction timeout during upgrade#1157

Merged
acs-bot merged 1 commit intoAzure:masterfrom
zachpuck:wait-for-delete-timeout
Apr 26, 2019
Merged

fix: use cordon/drain timeout for pod eviction timeout during upgrade#1157
acs-bot merged 1 commit intoAzure:masterfrom
zachpuck:wait-for-delete-timeout

Conversation

@zachpuck
Copy link
Contributor

Reason for Change:

When testing changes from PR #938 I found that the WaitForDelete call to delete/evict a pod was still using a 10s timeout. This caused some pods to not evict in time and the upgrade to fail. To quickly address this I have updated the getKubernetesClient to allow the cordonDrainTimeout to be passed in.

Issue Fixed:

Fixes #930

Requirements:

Notes:

@welcome
Copy link

welcome bot commented Apr 26, 2019

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@zachpuck
Copy link
Contributor Author

/assign @jackfrancis

@jackfrancis
Copy link
Member

lgtm pending upgrade tests (in-progress)

@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #1157 into master will decrease coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
- Coverage   74.91%   74.91%   -0.01%     
==========================================
  Files         131      131              
  Lines       18458    18457       -1     
==========================================
- Hits        13828    13827       -1     
  Misses       3837     3837              
  Partials      793      793

@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label Apr 26, 2019
@acs-bot
Copy link

acs-bot commented Apr 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, zachpuck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot merged commit b574f4a into Azure:master Apr 26, 2019
@welcome
Copy link

welcome bot commented Apr 26, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Fails due to node drain timeout

3 participants