fix: use cordon/drain timeout for pod eviction timeout during upgrade#1157
fix: use cordon/drain timeout for pod eviction timeout during upgrade#1157acs-bot merged 1 commit intoAzure:masterfrom
Conversation
|
💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - |
|
/assign @jackfrancis |
|
lgtm pending upgrade tests (in-progress) |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
- Coverage 74.91% 74.91% -0.01%
==========================================
Files 131 131
Lines 18458 18457 -1
==========================================
- Hits 13828 13827 -1
Misses 3837 3837
Partials 793 793 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, zachpuck The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Reason for Change:
When testing changes from PR #938 I found that the
WaitForDeletecall to delete/evict a pod was still using a 10s timeout. This caused some pods to not evict in time and the upgrade to fail. To quickly address this I have updated the getKubernetesClient to allow thecordonDrainTimeoutto be passed in.Issue Fixed:
Fixes #930
Requirements:
Notes: