This repository was archived by the owner on Oct 24, 2023. It is now read-only.
fix: increase cordon/drain timeout to 20 mins during upgrade#938
Merged
jackfrancis merged 3 commits intoAzure:masterfrom Apr 3, 2019
Merged
fix: increase cordon/drain timeout to 20 mins during upgrade#938jackfrancis merged 3 commits intoAzure:masterfrom
jackfrancis merged 3 commits intoAzure:masterfrom
Conversation
Member
|
lgtm |
Contributor
|
lgtm I would call this a |
Contributor
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
CecileRobertMichon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #938 +/- ##
=======================================
Coverage 73.35% 73.35%
=======================================
Files 130 130
Lines 17717 17717
=======================================
Hits 12996 12996
Misses 4024 4024
Partials 697 697 |
Contributor
|
Do we have a test signal for an upgrade with this change? |
Member
Author
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
There are cluster configuration scenarios (e.g., vms that have lots of persistent volumes) for which a 1 minute cordon/drain timeout isn't sufficiently long. Let's unblock these quickly by increasing the timeout to 20 mins. A // TODO for later is to make this a user-configurable timeout.
Issue Fixed:
Fixes #930
Requirements:
Notes: