feat: allow iptables mode for dualstack 1.18+ by aramase · Pull Request #2882 · Azure/aks-engine

aramase · 2020-03-11T21:33:41Z

Reason for Change:

iptables proxier support for dualstack has been added in 1.18.0-alpha.2. The PR allows using iptables proxy mode in 1.18+ versions.
Set different cluster subnet for 1.16 dualstack cluster
Update dualstack docs

Issue Fixed:

fixes #2868

Requirements:

uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version

Notes:

codecov · 2020-03-11T21:47:30Z

Codecov Report

Merging #2882 into master will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #2882   +/-   ##
=======================================
  Coverage   72.46%   72.47%           
=======================================
  Files         140      140           
  Lines       25677    25683    +6     
=======================================
+ Hits        18608    18614    +6     
  Misses       5993     5993           
  Partials     1076     1076

Impacted Files	Coverage Δ
pkg/api/vlabs/validate.go	`78.82% <55.55%> (+0.02%)`	⬆️
pkg/api/defaults.go	`92.23% <100.00%> (+0.06%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb68c7f...429e317. Read the comment docs.

pkg/api/defaults.go

jackfrancis

/lgtm

(cherry picked from commit ff5362e)

* feat: add support for Kubernetes 1.18.0-beta.1 (#2791) * feat: add support for Kubernetes 1.18.0-beta.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md/#v1180-beta1 * fix: windows support .zip URL (cherry picked from commit 34706cf) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * test: fix test TestGetProvisionScriptParametersCommon and TestGetK8sVersionComponents * feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback (cherry picked from commit 8be7000) * feat: Experimental support for Windows+ContainerD (#1322) (cherry picked from commit b068aa7) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Mark Rossetti <marosset@microsoft.com>

(cherry picked from commit ff5362e)

…3076) * test: fix test TestGetK8sVersionComponents and TestGetProvisionScriptParametersCommon * feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback (cherry picked from commit 8be7000) * feat: add support for Kubernetes 1.18.0-beta.1 (#2791) * feat: add support for Kubernetes 1.18.0-beta.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md/#v1180-beta1 * fix: windows support .zip URL (cherry picked from commit 34706cf) * feat: Experimental support for Windows+ContainerD (#1322) (cherry picked from commit b068aa7) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * fix: make build with go 1.14 (#3005) (cherry picked from commit 509bc9c) * feat: add support for Kubernetes 1.18.1 (#3045) * feat: add support for Kubernetes 1.18.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180 * ci: test PRs with k8s 1.18 (cherry picked from commit 66ff61c) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>

(cherry picked from commit ff5362e)

…18.2 (#3194) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * fix: make build with go 1.14 (#3005) (cherry picked from commit 509bc9c) * feat: add support for Kubernetes 1.18.1 (#3045) * feat: add support for Kubernetes 1.18.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180 * ci: test PRs with k8s 1.18 (cherry picked from commit 66ff61c) * feat: add support for Kubernetes 1.18.2 (#3089) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1181 (cherry picked from commit 8ebece1) * Revert "Revert windowszip path" This reverts commit 8db438e. * Update KubeBinariesSASURLBase to new path. Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>

feat: allow iptables mode for dualstack for 1.18+

0699baa

aramase added the do-not-merge/work-in-progress label Mar 11, 2020

jackfrancis reviewed Mar 11, 2020

View reviewed changes

pkg/api/defaults.go Outdated Show resolved Hide resolved

aramase removed the do-not-merge/work-in-progress label Mar 11, 2020

Review feedback

429e317

aramase force-pushed the dualstack-enable-iptables branch from b5ede2b to 429e317 Compare March 11, 2020 22:58

aramase changed the title ~~feat: allow iptables mode for dualstack for 1.18+~~ feat: allow iptables mode for dualstack 1.18+ Mar 11, 2020

jackfrancis approved these changes Mar 11, 2020

View reviewed changes

jackfrancis merged commit ff5362e into Azure:master Mar 12, 2020

aramase deleted the dualstack-enable-iptables branch March 12, 2020 01:46

fmotrifork mentioned this pull request Mar 23, 2020

aks-engine 0.48.0 fishworks/fish-food#639

Merged

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Mar 29, 2020

feat: allow iptables mode for dualstack 1.18+ (Azure#2882)

bb5ccc2

(cherry picked from commit ff5362e)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Mar 30, 2020

feat: allow iptables mode for dualstack 1.18+ (Azure#2882)

74f987d

(cherry picked from commit ff5362e)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Mar 30, 2020

feat: allow iptables mode for dualstack 1.18+ (Azure#2882)

0d1404a

(cherry picked from commit ff5362e)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Apr 16, 2020

feat: allow iptables mode for dualstack 1.18+ (Azure#2882)

5030660

(cherry picked from commit ff5362e)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Apr 16, 2020

feat: allow iptables mode for dualstack 1.18+ (Azure#2882)

2849e76

(cherry picked from commit ff5362e)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Apr 26, 2020

feat: allow iptables mode for dualstack 1.18+ (Azure#2882)

d4aab84

(cherry picked from commit ff5362e)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request May 5, 2020

feat: allow iptables mode for dualstack 1.18+ (Azure#2882)

3c9f788

(cherry picked from commit ff5362e)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request May 5, 2020

feat: allow iptables mode for dualstack 1.18+ (Azure#2882)

2eeb29a

(cherry picked from commit ff5362e)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request May 5, 2020

feat: allow iptables mode for dualstack 1.18+ (Azure#2882)

ae20d2e

(cherry picked from commit ff5362e)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow iptables mode for dualstack 1.18+#2882

feat: allow iptables mode for dualstack 1.18+#2882
jackfrancis merged 2 commits intoAzure:masterfrom
aramase:dualstack-enable-iptables

aramase commented Mar 11, 2020 •

edited

Loading

Uh oh!

codecov bot commented Mar 11, 2020 •

edited

Loading

Uh oh!

Uh oh!

jackfrancis left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aramase commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

jackfrancis left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aramase commented Mar 11, 2020 •

edited

Loading

codecov bot commented Mar 11, 2020 •

edited

Loading