feat: add support for Kubernetes 1.18.0 by mboersma · Pull Request #2957 · Azure/aks-engine

mboersma · 2020-03-24T15:19:13Z

Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md

Issue Fixed:
Closes #2923

Requirements:

Kubernetes artifacts built and pushed by Azure Pipelines
uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version

Notes:
This will fail until Kubernetes 1.18.0 is actually released ~~today~~ tomorrow and our pipeline does its thing.

mboersma · 2020-03-24T15:19:44Z

/hold

Still awaiting release and publication. 🏃

mboersma · 2020-03-24T15:26:55Z

pkg/api/common/versions.go

+	"1.18.0-alpha.2": false,
+	"1.18.0-alpha.3": false,
+	"1.18.0-alpha.5": false,
+	"1.18.0-beta.1":  false,


Should we add false entries for 1.18.0-beta.2 and 1.18.0-rc.1? AKS Engine never supported either one due to bugs, but we could add them in order to reference the issues.

Let's do, good call.

pkg/api/vlabs/validate_test.go

codecov · 2020-03-24T15:32:36Z

Codecov Report

Merging #2957 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2957   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files         141      141           
  Lines       25889    25889           
=======================================
  Hits        18790    18790           
  Misses       6005     6005           
  Partials     1094     1094

mboersma · 2020-03-24T17:28:41Z

Update: the 1.18 release is postponed until tomorrow (Weds. 3/25).

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md

jackfrancis

/lgtm

acs-bot · 2020-03-26T03:12:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

* feat: add support for Kubernetes 1.18.0-beta.1 (#2791) * feat: add support for Kubernetes 1.18.0-beta.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md/#v1180-beta1 * fix: windows support .zip URL (cherry picked from commit 34706cf) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * test: fix test TestGetProvisionScriptParametersCommon and TestGetK8sVersionComponents * feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback (cherry picked from commit 8be7000) * feat: Experimental support for Windows+ContainerD (#1322) (cherry picked from commit b068aa7) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Mark Rossetti <marosset@microsoft.com>

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

…3076) * test: fix test TestGetK8sVersionComponents and TestGetProvisionScriptParametersCommon * feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback (cherry picked from commit 8be7000) * feat: add support for Kubernetes 1.18.0-beta.1 (#2791) * feat: add support for Kubernetes 1.18.0-beta.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md/#v1180-beta1 * fix: windows support .zip URL (cherry picked from commit 34706cf) * feat: Experimental support for Windows+ContainerD (#1322) (cherry picked from commit b068aa7) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * fix: make build with go 1.14 (#3005) (cherry picked from commit 509bc9c) * feat: add support for Kubernetes 1.18.1 (#3045) * feat: add support for Kubernetes 1.18.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180 * ci: test PRs with k8s 1.18 (cherry picked from commit 66ff61c) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

…18.2 (#3194) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * fix: make build with go 1.14 (#3005) (cherry picked from commit 509bc9c) * feat: add support for Kubernetes 1.18.1 (#3045) * feat: add support for Kubernetes 1.18.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180 * ci: test PRs with k8s 1.18 (cherry picked from commit 66ff61c) * feat: add support for Kubernetes 1.18.2 (#3089) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1181 (cherry picked from commit 8ebece1) * Revert "Revert windowszip path" This reverts commit 8db438e. * Update KubeBinariesSASURLBase to new path. Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>

acs-bot added the size/M label Mar 24, 2020

acs-bot added do-not-merge/hold approved labels Mar 24, 2020

mboersma commented Mar 24, 2020

View reviewed changes

pkg/api/vlabs/validate_test.go Show resolved Hide resolved

jackfrancis force-pushed the add-k8s-1.18.0 branch from 5f64e94 to 86fd245 Compare March 25, 2020 23:02

feat: add support for Kubernetes 1.18.0

849fda9

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md

jackfrancis force-pushed the add-k8s-1.18.0 branch from 86fd245 to 849fda9 Compare March 26, 2020 01:16

jackfrancis removed the do-not-merge/hold label Mar 26, 2020

jackfrancis approved these changes Mar 26, 2020

View reviewed changes

acs-bot assigned jackfrancis Mar 26, 2020

acs-bot added the lgtm label Mar 26, 2020

jackfrancis merged commit 6dadaf0 into Azure:master Mar 26, 2020

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Mar 29, 2020

feat: add support for Kubernetes 1.18.0 (Azure#2957)

3f4760f

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Mar 30, 2020

feat: add support for Kubernetes 1.18.0 (Azure#2957)

f6d7593

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Mar 30, 2020

feat: add support for Kubernetes 1.18.0 (Azure#2957)

c74e48c

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

mboersma deleted the add-k8s-1.18.0 branch April 9, 2020 20:11

fmotrifork mentioned this pull request Apr 14, 2020

aks-engine 0.49.0 fishworks/fish-food#678

Merged

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Apr 16, 2020

feat: add support for Kubernetes 1.18.0 (Azure#2957)

ae4b9cf

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Apr 16, 2020

feat: add support for Kubernetes 1.18.0 (Azure#2957)

283c99b

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Apr 26, 2020

feat: add support for Kubernetes 1.18.0 (Azure#2957)

23d86b0

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request May 5, 2020

feat: add support for Kubernetes 1.18.0 (Azure#2957)

8c3f9b9

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request May 5, 2020

feat: add support for Kubernetes 1.18.0 (Azure#2957)

4bc455f

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request May 5, 2020

feat: add support for Kubernetes 1.18.0 (Azure#2957)

cb86c87

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for Kubernetes 1.18.0#2957

feat: add support for Kubernetes 1.18.0#2957
jackfrancis merged 1 commit intoAzure:masterfrom
mboersma:add-k8s-1.18.0

mboersma commented Mar 24, 2020 •

edited

Loading

Uh oh!

mboersma commented Mar 24, 2020

Uh oh!

mboersma Mar 24, 2020

Uh oh!

jackfrancis Mar 24, 2020

Uh oh!

Uh oh!

codecov bot commented Mar 24, 2020 •

edited

Loading

Uh oh!

mboersma commented Mar 24, 2020

Uh oh!

jackfrancis left a comment

Uh oh!

acs-bot commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mboersma commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mboersma commented Mar 24, 2020

Uh oh!

mboersma Mar 24, 2020

Choose a reason for hiding this comment

Uh oh!

jackfrancis Mar 24, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mboersma commented Mar 24, 2020

Uh oh!

jackfrancis left a comment

Choose a reason for hiding this comment

Uh oh!

acs-bot commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mboersma commented Mar 24, 2020 •

edited

Loading

codecov bot commented Mar 24, 2020 •

edited

Loading