Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.18.0-rc.1#2923

Closed
mboersma wants to merge 2 commits intoAzure:masterfrom
mboersma:add-k8s-1.18.0-rc.1
Closed

feat: add support for Kubernetes 1.18.0-rc.1#2923
mboersma wants to merge 2 commits intoAzure:masterfrom
mboersma:add-k8s-1.18.0-rc.1

Conversation

@mboersma
Copy link
Member

@mboersma mboersma commented Mar 18, 2020

Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180-beta2

Issue Fixed:
Closes #2879

Requirements:

  • Kubernetes artifacts published by Azure Pipelines
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:

@acs-bot
Copy link

acs-bot commented Mar 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2923 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2923   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files         141      141           
  Lines       25934    25934           
=======================================
  Hits        18821    18821           
  Misses       6014     6014           
  Partials     1099     1099

@mboersma
Copy link
Member Author

This is failing in 1.18.0-rc.1 because expected master & agent node labels have not been applied.

@mboersma mboersma force-pushed the add-k8s-1.18.0-rc.1 branch 2 times, most recently from c22645c to 849ed5b Compare March 19, 2020 14:03
@mboersma
Copy link
Member Author

This PR is blocked by kubernetes/kubernetes#89276.

@mboersma mboersma force-pushed the add-k8s-1.18.0-rc.1 branch from 849ed5b to aec5b5c Compare March 23, 2020 18:16
@acs-bot acs-bot added size/XS and removed size/M labels Mar 23, 2020
@mboersma mboersma force-pushed the add-k8s-1.18.0-rc.1 branch from aec5b5c to b78a2f1 Compare March 23, 2020 18:43
@mboersma mboersma deleted the add-k8s-1.18.0-rc.1 branch April 10, 2020 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants