This repository was archived by the owner on Oct 24, 2023. It is now read-only.
fix: validate signed powershell packages in Azure and China Cloud#3579
Merged
jsturtevant merged 2 commits intoAzure:masterfrom Jul 7, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3579 +/- ##
=======================================
Coverage 73.16% 73.16%
=======================================
Files 147 147
Lines 25097 25097
=======================================
Hits 18362 18362
Misses 5604 5604
Partials 1131 1131 Continue to review full report at Codecov.
|
mboersma
changed the title
jsturtevant
changed the title
ksubrmnn
approved these changes
Jul 7, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant, ksubrmnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
penggu
pushed a commit
to penggu/aks-engine
that referenced
this pull request
Oct 28, 2020
…ure#3579) * validate packages in Azure and China Cloud * update docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The pr #3441 added signing of the powershell scripts for China Cloud but the validation script was not update to reflect the change.
Issue Fixed:
Requirements:
Notes: