feat: Consume signed powershell scripts#3441
Conversation
marosset
changed the title
|
/azp run pr-e2e |
|
Pull request contains merge conflicts. |
marosset
force-pushed
the
consumed-signed-powershell
branch
from
a96c825 to
cc4828c
Compare
marosset
changed the title
pkg/api/const.go
Outdated
| // WindowsProfile defaults | ||
| // TODO: Move other values defined in WindowsProfiles (like DefaultWindowsSSHEnabled) here. | ||
| const ( | ||
| DefaultWindowsProvisioningScriptsPackageURL = "https://kubernetesartifacts.azureedge.net/aks-engine/windows/provisioning/signedscripts-v0.0.1.zip" |
There was a problem hiding this comment.
Should we add this to DefaultKubernetesSpecConfig in azenvtypes.go?
We need to assure that the new package is ready for AzureChinaCloud. AzureChinaCloud should use https://mirror.azk8s.cn/aks-engine.
I think that we should have a rule to manage so many folders for different packages so we do not need to reconfigure the proxy for AzureChinaCloud.
FYI @andyzhangx
There was a problem hiding this comment.
@jchauncey would you also sync this https://kubernetesartifacts.azureedge.net/aks-engine to https://kubernetesartifacts.core.chinacloudapi.cn/aks-engine, every bits in https://kubernetesartifacts.azureedge.net should sync to https://kubernetesartifacts.core.chinacloudapi.cn otherwise it may break sth on Azure China.
There was a problem hiding this comment.
@AbelHu @andyzhangx I see if the Azure DevOps release pipeline that this package was uploaded to https://kubernetesartifacts.blob.core.chinacloudapi.cn/aks-engine/windows/provisioning/signedscripts-v0.0.1.zip.
@AbelHu are you saying that we should add an entry to KubernetesSpecConfig that points to https://kubernetesartifacts.azureedge.net/aks-engine by default?
I'm not familiar with how other URLs for AzureChinaCloud are managed by aks-engine.
If you have an example to follow I would appreciate it.
Also @jackfrancis as FYI here
There was a problem hiding this comment.
I think that we need to add a new property WindowsProvisioningScriptsPackageURL in KubernetesSpecConfig, set DefaultKubernetesSpecConfig.WindowsProvisioningScriptsPackageURL to "https://kubernetesartifacts.azureedge.net/aks-engine/windows/provisioning/signedscripts-" + SignedWindowsScriptsVer + ".zip" for global Azure and expect to set AzureChinaCloudSpec.KubernetesSpecConfig.WindowsProvisioningScriptsPackageURL to "https://mirror.azk8s.cn/aks-engine/windows/provisioning/signedscripts-" + SignedWindowsScriptsVer + ".zip".
There was a problem hiding this comment.
@AbelHu @andyzhangx please take a look at the last commit in the PR where I added WindowsProvisioningScriptsPackageURL to kubernetesSpecConfig
marosset
force-pushed
the
consumed-signed-powershell
branch
from
ea9e31b to
bb32b52
Compare
Codecov Report
@@ Coverage Diff @@
## master #3441 +/- ##
==========================================
+ Coverage 73.17% 73.19% +0.01%
==========================================
Files 147 147
Lines 25034 25051 +17
==========================================
+ Hits 18319 18336 +17
- Misses 5581 5585 +4
+ Partials 1134 1130 -4
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AbelHu, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* moving some windows powershell scripts to a new staging directory * powershell updates to download package and add files to c:\k * removing references to provisioning scripts from c:/azuredata/ * adding validate-windows-provisioning-scripts.sh * Adding build-windows-provisioning-scripts.sh * Adding windows-provisioning-scripts.md * Updating references to a package containing signed powershell files * ensuring windows scripts package works in azure china cloud
6 participants
Reason for Change:
Issue Fixed:
Requirements:
Notes: