Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

feat: add hosts config agent support for Windows nodes#3572

Merged
jsturtevant merged 1 commit intoAzure:masterfrom
feiskyer:windows-hosts-agent
Jul 7, 2020
Merged

feat: add hosts config agent support for Windows nodes#3572
jsturtevant merged 1 commit intoAzure:masterfrom
feiskyer:windows-hosts-agent

Conversation

@feiskyer
Copy link
Member

@feiskyer feiskyer commented Jul 2, 2020

Reason for Change:

Follow up of #3556: add hosts config agent support for Windows nodes

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/L label Jul 2, 2020
@feiskyer
Copy link
Member Author

feiskyer commented Jul 2, 2020

the first commit is coming from #3556, needs a rebase after it gets merged.

@feiskyer feiskyer force-pushed the windows-hosts-agent branch from 131911a to e0f94a6 Compare July 2, 2020 07:10
@acs-bot acs-bot added size/XL and removed size/L labels Jul 2, 2020
@feiskyer
Copy link
Member Author

feiskyer commented Jul 2, 2020

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@feiskyer feiskyer force-pushed the windows-hosts-agent branch from e0f94a6 to e716b58 Compare July 2, 2020 08:57
@feiskyer
Copy link
Member Author

feiskyer commented Jul 2, 2020

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsturtevant
Copy link
Contributor

Look like there was at least one debugging TODO left. Also want to minimize the noise in the logs so we don't fill them up since the call runs regularly.

A rebase will be need for recent changes to the powershell. We moved the powershell scripts due to signing requirements: #3441. There are instructions in the PR that demonstrate where the PS should live, how to test and how to make updates but the functionality itself should stay similar. Let me know if you have questions.

@feiskyer feiskyer force-pushed the windows-hosts-agent branch from e716b58 to e001552 Compare July 3, 2020 02:09
@acs-bot acs-bot added size/L and removed size/XL labels Jul 3, 2020
@feiskyer feiskyer force-pushed the windows-hosts-agent branch from e001552 to 8f4f6f2 Compare July 3, 2020 02:53
@feiskyer
Copy link
Member Author

feiskyer commented Jul 3, 2020

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@feiskyer feiskyer force-pushed the windows-hosts-agent branch from 8f4f6f2 to 89111af Compare July 3, 2020 03:40
@feiskyer
Copy link
Member Author

feiskyer commented Jul 3, 2020

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #3572 into master will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3572   +/-   ##
=======================================
  Coverage   73.16%   73.17%           
=======================================
  Files         147      147           
  Lines       25097    25110   +13     
=======================================
+ Hits        18362    18373   +11     
- Misses       5604     5605    +1     
- Partials     1131     1132    +1     
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 53.61% <77.77%> (+0.15%) ⬆️
pkg/api/types.go 94.24% <100.00%> (+0.02%) ⬆️
pkg/engine/armvariables.go 86.25% <100.00%> (+0.02%) ⬆️
pkg/engine/template_generator.go 81.96% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4521ec4...56a665a. Read the comment docs.

@feiskyer
Copy link
Member Author

feiskyer commented Jul 6, 2020

@jsturtevant could you help to have a look again?

@feiskyer feiskyer force-pushed the windows-hosts-agent branch from 89111af to 56a665a Compare July 7, 2020 04:56
@feiskyer
Copy link
Member Author

feiskyer commented Jul 7, 2020

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@feiskyer
Copy link
Member Author

feiskyer commented Jul 7, 2020

@jsturtevant could you help to have a look again?

@feiskyer
Copy link
Member Author

feiskyer commented Jul 7, 2020

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsturtevant
Copy link
Contributor

/lgtm

@acs-bot
Copy link

acs-bot commented Jul 7, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: feiskyer, jsturtevant
To complete the pull request process, please assign mboersma
You can assign the PR to them by writing /assign @mboersma in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsturtevant jsturtevant merged commit b9a067a into Azure:master Jul 7, 2020
@feiskyer feiskyer deleted the windows-hosts-agent branch July 8, 2020 02:48
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants