Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

chore: Update the signed powershell package version#3584

Merged
jsturtevant merged 1 commit intoAzure:masterfrom
jsturtevant:chore/update-signed-powershells
Jul 13, 2020
Merged

chore: Update the signed powershell package version#3584
jsturtevant merged 1 commit intoAzure:masterfrom
jsturtevant:chore/update-signed-powershells

Conversation

@jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented Jul 8, 2020

Reason for Change:

Updates the signed powershell package to include new file introduced in #3572

Issue Fixed:

Requirements:

Notes:
/cc @AbelHu @feiskyer

Follows update procedure from https://github.com/Azure/aks-engine/blob/master/docs/topics/windows-provisioning-scripts.md#updates

@acs-bot acs-bot requested review from AbelHu and feiskyer July 8, 2020 18:25
@acs-bot acs-bot added the size/XS label Jul 8, 2020
@jsturtevant
Copy link
Contributor Author

/assign @ksubrmnn

@jsturtevant
Copy link
Contributor Author

/retest

@feiskyer
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Jul 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AbelHu, feiskyer, jsturtevant, ksubrmnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsturtevant
Copy link
Contributor Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #3584 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3584      +/-   ##
==========================================
+ Coverage   73.17%   73.18%   +0.01%     
==========================================
  Files         147      147              
  Lines       25110    25122      +12     
==========================================
+ Hits        18373    18385      +12     
  Misses       5605     5605              
  Partials     1132     1132              
Impacted Files Coverage Δ
pkg/api/types.go 94.24% <0.00%> (ø)
pkg/api/vlabs/types.go 71.83% <0.00%> (ø)
pkg/engine/templates_generated.go 53.61% <0.00%> (ø)
pkg/api/converterfromapi.go 94.05% <0.00%> (+0.01%) ⬆️
pkg/api/convertertoapi.go 93.56% <0.00%> (+0.01%) ⬆️
pkg/api/defaults.go 92.81% <0.00%> (+0.02%) ⬆️
pkg/engine/template_generator.go 82.03% <0.00%> (+0.07%) ⬆️
pkg/api/vlabs/validate.go 80.62% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 509ea12...f58503e. Read the comment docs.

@jsturtevant
Copy link
Contributor Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsturtevant jsturtevant merged commit bb83c22 into Azure:master Jul 13, 2020
AbelHu pushed a commit to AbelHu/aks-engine that referenced this pull request Jul 16, 2020
AbelHu pushed a commit to AbelHu/aks-engine that referenced this pull request Jul 16, 2020
AbelHu pushed a commit to AbelHu/aks-engine that referenced this pull request Jul 16, 2020
AbelHu pushed a commit to AbelHu/aks-engine that referenced this pull request Jul 21, 2020
AbelHu pushed a commit to AbelHu/aks-engine that referenced this pull request Jul 21, 2020
AbelHu added a commit that referenced this pull request Jul 24, 2020
…onfig agent support for Windows (#3630)

* Add staging Windows scripts

* Update parts folder for Windows

* feat: Consume signed powershell scripts

* update the signed package version (#3584)

* fix: use mcr.azk8s.cn for Azure CNI in China cloud

* feat: add hosts config agent support for Windows nodes

* Generate templates_generated.go

* feat: Experimental support for Windows+ContainerD (#1322)

* chore: update Windows default VHD for July (#3619)

* fix

Co-authored-by: James Sturtevant <jstur@microsoft.com>
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants