Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

Add support for Kubernetes 1.12.3#57

Merged
jackfrancis merged 2 commits intoAzure:masterfrom
mboersma:k8s-1.12.3
Nov 29, 2018
Merged

Add support for Kubernetes 1.12.3#57
jackfrancis merged 2 commits intoAzure:masterfrom
mboersma:k8s-1.12.3

Conversation

@mboersma
Copy link
Member

@mboersma mboersma commented Nov 26, 2018

What this PR does / why we need it:

See https://github.com/kubernetes/kubernetes/releases/tag/v1.12.3

TODO:

  • upload Windows binary

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Add support for Kubernetes 1.12.3

@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   52.42%   52.42%           
=======================================
  Files          91       91           
  Lines       12804    12804           
=======================================
  Hits         6713     6713           
  Misses       5483     5483           
  Partials      608      608

@mboersma mboersma mentioned this pull request Nov 26, 2018
4 tasks
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sylr
Copy link
Contributor

sylr commented Nov 27, 2018

/lgtm

@acs-bot
Copy link

acs-bot commented Nov 27, 2018

@sylr: changing LGTM is restricted to assignees, and only Azure/aks-engine repo collaborators may be assigned issues.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label Nov 29, 2018
@jackfrancis jackfrancis merged commit 92fc613 into Azure:master Nov 29, 2018
@acs-bot
Copy link

acs-bot commented Nov 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis, mboersma, sylr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants