Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

Add support for Kubernetes 1.11.5#58

Merged
mboersma merged 2 commits intoAzure:masterfrom
mboersma:k8s-1.11.5
Nov 27, 2018
Merged

Add support for Kubernetes 1.11.5#58
mboersma merged 2 commits intoAzure:masterfrom
mboersma:k8s-1.11.5

Conversation

@mboersma
Copy link
Member

@mboersma mboersma commented Nov 26, 2018

What this PR does / why we need it:

See https://github.com/kubernetes/kubernetes/releases/tag/v1.11.5

TODO:

  • upload Windows binary

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Add support for Kubernetes 1.11.5

@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   52.44%   52.44%           
=======================================
  Files          91       91           
  Lines       12801    12801           
=======================================
  Hits         6713     6713           
  Misses       5480     5480           
  Partials      608      608

ContainerMonitoringAddonName: "oms:ciprod10162018-2",
AzureCNINetworkMonitoringAddonName: "networkmonitor:v0.0.4",
"cluster-autoscaler": "cluster-autoscaler:v1.3.0",
"cluster-autoscaler": "cluster-autoscaler:v1.3.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come the autoscaler version for 1.11 (1.3.4) is greater than the one for 1.12 (1.3.3)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've failed to update it in the past. I'm just going off the updated versions in the release notes. For 1.12.3 the component version is actually bumped to v1.12.1 now, see #57.

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Nov 26, 2018
@acs-bot
Copy link

acs-bot commented Nov 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma merged commit a420dd5 into Azure:master Nov 27, 2018
@mboersma mboersma deleted the k8s-1.11.5 branch November 27, 2018 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants