Skip to content

Comments

Mitigate breaking change for optional parameter change#3686

Merged
live1206 merged 57 commits intoAzure:feature/v3from
live1206:overload-mitigation
Dec 8, 2023
Merged

Mitigate breaking change for optional parameter change#3686
live1206 merged 57 commits intoAzure:feature/v3from
live1206:overload-mitigation

Conversation

@live1206
Copy link
Member

@live1206 live1206 commented Aug 24, 2023 •
edited
Loading

Fixes #3596.

This PR introduces SignatureType, it holds three portions of code:

  • current
  • custom
  • baseline contract
    current union custom compare with previous contract outputs the changeset, with it we can apply different rules with

It provides

  • OverloadingMethods: for now represents the missing methods in baseline contract due to additional optional parameters in the new contract, this is causing breaking changes
  • MethodsToSkip: represents the methods already defined in custom code, the writer should skip them while writing to the output

@live1206 live1206 added the Mgmt This issue is related to a management-plane library. label Aug 24, 2023
archerzz
archerzz reviewed Aug 24, 2023
View reviewed changes
@live1206
Copy link
Member Author

live1206 commented Aug 29, 2023

@m-nash Please take a look at this PR, it mitigates breaking changes for additional optional parameters in model factory.

ArcturusZhang
ArcturusZhang reviewed Sep 15, 2023
View reviewed changes
ArcturusZhang
ArcturusZhang reviewed Sep 15, 2023
View reviewed changes
@live1206 live1206 mentioned this pull request Sep 15, 2023
Closed
@live1206 live1206 requested a review from hallipr as a code owner December 4, 2023 03:17
ArcturusZhang
ArcturusZhang reviewed Dec 4, 2023
View reviewed changes
live1206
live1206 commented Dec 5, 2023
View reviewed changes
@azure-sdk azure-sdk mentioned this pull request Dec 6, 2023
Closed
ArcturusZhang
ArcturusZhang reviewed Dec 7, 2023
View reviewed changes
@azure-sdk azure-sdk mentioned this pull request Dec 7, 2023
Closed
@live1206 live1206 merged commit 10de73e into Azure:feature/v3 Dec 8, 2023
@live1206 live1206 deleted the overload-mitigation branch December 8, 2023 03:04
@ArcturusZhang ArcturusZhang mentioned this pull request Dec 8, 2023
Closed
6 tasks
live1206 added a commit to live1206/autorest.csharp that referenced this pull request Dec 8, 2023
@live1206
Revert "Mitigate breaking change for optional parameter change (Azure…
b3d42dc 
…#3686)"

This reverts commit 10de73e.
live1206 added a commit that referenced this pull request Dec 8, 2023
@live1206
Revert "Mitigate breaking change for optional parameter change (#3686)…
eee12d7 
…" (#4023)

This reverts commit 10de73e.
live1206 added a commit to live1206/autorest.csharp that referenced this pull request Dec 8, 2023
@live1206
Reapply "Mitigate breaking change for optional parameter change (Azur…
c0617a8 
…e#3686)" (Azure#4023)

This reverts commit eee12d7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@ArthurMa1978 ArthurMa1978 ArthurMa1978 approved these changes

@m-nash m-nash Awaiting requested review from m-nash

@jsquire jsquire Awaiting requested review from jsquire

@lirenhe lirenhe Awaiting requested review from lirenhe

@hallipr hallipr Awaiting requested review from hallipr

+1 more reviewer

@archerzz archerzz archerzz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Overload function to allow method signature change for Model Factory - parameter

4 participants

@live1206 @archerzz @ArcturusZhang @ArthurMa1978