Skip to content

Comments

Fix the issue when generating overloads for modelfactories#4020

Closed
ArcturusZhang wants to merge 4 commits intoAzure:feature/v3from
ArcturusZhang:resolve-issues-for-modelfactory-overloads
Closed

Fix the issue when generating overloads for modelfactories#4020
ArcturusZhang wants to merge 4 commits intoAzure:feature/v3from
ArcturusZhang:resolve-issues-for-modelfactory-overloads

Conversation

@ArcturusZhang
Copy link
Member

Description

This fixes the regen failures for HLC and DPG packages after #3686

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@live1206
Copy link
Member

live1206 commented Dec 8, 2023

Continue with work in #4026 since the original PR was reverted.

@live1206 live1206 closed this Dec 8, 2023
@ArcturusZhang ArcturusZhang deleted the resolve-issues-for-modelfactory-overloads branch December 11, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants