Mitigate breaking change of optional parameter change for ModelFactory#4026
Merged
live1206 merged 43 commits intoAzure:feature/v3from Jan 17, 2024
Merged
Mitigate breaking change of optional parameter change for ModelFactory#4026live1206 merged 43 commits intoAzure:feature/v3from
live1206 merged 43 commits intoAzure:feature/v3from
Conversation
…e#3686)" (Azure#4023) This reverts commit eee12d7.
6 tasks
6 tasks
src/AutoRest.CSharp/Common/AutoRest/Plugins/GeneratedCodeWorkspace.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Output/Models/OverloadMethodSignature.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Output/Models/Types/ModelFactoryTypeProvider.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Generation/Writers/CodeWriterExtensions.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Generation/Writers/ModelFactoryWriter.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/AutoRest/Plugins/GeneratedCodeWorkspace.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Output/Models/Types/SignatureType.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Generation/Writers/CodeWriterExtensions.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Output/Models/Types/ModelFactoryTypeProvider.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Output/Models/Types/SignatureType.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Output/Models/Types/SignatureType.cs
Outdated
Show resolved
Hide resolved
ArthurMa1978
approved these changes
Jan 12, 2024
…/autorest.csharp into overload-breakingchange
…/autorest.csharp into overload-breakingchange
ArcturusZhang
approved these changes
Jan 16, 2024
Member
Author
|
Pending on Azure/azure-sdk-for-net#41322 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3596.
This PR introduces
SignatureType, it holds three portions of code:current union customcompare withprevious contractoutputs the changeset, with it we can apply different rules withIt provides
This feature is only enabled for Mgmt.
ApiCompatVersionis not set in .csprojTypeFactory.TryCreateTypesinceCsharpTypedoes not represent them properly for now.