[AKS] fix regression from ARM mgmt sdk change#2129
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
|
Add @zhoxing-ms who is responsible for |
|
@marwanad Hi, the code is fine, could you pelase re-run the deployment related tests in live mode? This can further ensure that the modification is correct |
|
@zhoxing-ms which was the command failing with latest CLI and extensions. I don't think the existing live tests in extensions exercise that scenario. I can look into adding this test case in a separate PR. Are the extension live recordings run frequently or is it only the CLI core ones that are run daily? |
|
@marwanad We always re-record yaml file through live test when the code has some change in the logic. In addition, we also have regular live test tasks for the CLI main repo. If you can ensure that all the deployment related parts in this extension are modified correctly, it is feasible to supplement the relevant tests with a separate PR, so I think this PR can be passed~ |
PR: Azure/azure-cli#14344 introduced a breaking change to azure-mgmt-resource which broke compatibility of the AKS CLI-extension with the latest CLI core.
This is based off the changes to preserve backwards compatibility in PR: ttps://github.com/Azure/azure-cli/pull/14344
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.