{ARM} Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01#14344
Merged
{ARM} Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01#14344
Conversation
zhoxing-ms
requested review from
Juliehzl,
arrownj,
bgklein,
bim-msft,
fengzhou-msft,
haroldrandom,
jaredmoo,
jiasli,
jsntcy,
mmyyrroonn,
qianwens,
qwordy,
samkreter and
v-Ajnava
as code owners
Collaborator
|
add to S173 |
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
from
80a33c2 to
ec4016c
Compare
zhoxing-ms
changed the title
bim-msft
approved these changes
Jul 16, 2020
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
3 times, most recently
from
ca579f1 to
ebcd759
Compare
zhoxing-ms
changed the title
fengzhou-msft
approved these changes
Jul 21, 2020
Contributor
There was a problem hiding this comment.
Is it a breaking change?
Contributor
Author
There was a problem hiding this comment.
Yes, it is a breaking change of SDK, and we did made some compatibility logic to ensure that the CLI will not be broken
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
2 times, most recently
from
3f167be to
aac6ad8
Compare
2 tasks
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
4 times, most recently
from
47b21b8 to
2374d54
Compare
zhoxing-ms
commented
Jul 24, 2020
Comment on lines
436
to
472
Contributor
Author
There was a problem hiding this comment.
Compatibility logic for breaking change from SDK
haroldrandom
approved these changes
Jul 24, 2020
mmyyrroonn
approved these changes
Jul 24, 2020
Contributor
mmyyrroonn
left a comment
mmyyrroonn
left a comment
There was a problem hiding this comment.
Approved for monitor commands
Juliehzl
approved these changes
Jul 24, 2020
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
approve for storage part
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
6 times, most recently
from
d7b4f58 to
515ac0d
Compare
arrownj
approved these changes
Jul 27, 2020
Contributor
arrownj
left a comment
arrownj
left a comment
There was a problem hiding this comment.
For VM module, it's good.
Contributor
Author
|
@samkreter Could you please help to review this PR for your part~ |
jiasli
approved these changes
Jul 27, 2020
jsntcy
reviewed
Jul 27, 2020
Member
There was a problem hiding this comment.
Does this comments affect test result? #Closed
Contributor
Author
There was a problem hiding this comment.
This is automatically generated and should not affect the test results #Closed
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
2 times, most recently
from
b5dde9b to
3f120b8
Compare
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
from
3f120b8 to
a043ea6
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01
For PR: #13429 #14241
At the same time, some compatibility logic was made for the breaking change of SDK to ensure that breaking will not be produced on the CLI side, such as: click
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.