{Compute} Remove credentials from recordings#16795
Merged
Conversation
Contributor
|
@qwordy You could use |
jiasli
commented
Feb 4, 2021
| class VMSSCrossTenantUpdateScenarioTest(LiveScenarioTest): | ||
|
|
||
| @ResourceGroupPreparer(name_prefix='cli_test_vmss_update_', location='westus2') | ||
| def test_vmss_cross_tenant_update(self, resource_group): |
Member
Author
There was a problem hiding this comment.
Rename the test name to keep in sync with test_vm_cross_tenant_update:
- test_vmss_update_cross_tenant
+ test_vmss_cross_tenant_update
Member
It was written by XXJ on 7/29/2020. |
Member
|
I remember there is bug in |
Member
Thank you so much! |
qwordy
approved these changes
Feb 5, 2021
zhoxing-ms
approved these changes
Feb 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14344, #14532 contains access tokens (credentials) in
x-ms-authorization-auxiliaryheaders.x-ms-authorization-auxiliarywill not be recorded anymore since Azure/azure-python-devtools@8915c3f, added by Azure/azure-python-devtools#46. This change is released inazure-devtools1.1.0.Azure CLI didn't take this change until #14477 which bumped
azure-devtoolsto 1.2.0 and was merged after #14344, #14532, so this issue is already fixed. Re-running the test won't recordx-ms-authorization-auxiliaryanymore.Actually, if a test is marked as
@live_only, no recording should be generated at all! This could be improved in the test framework.