Add NRG Profile + Restriction Level to the Preview CLI Update + Create paths#5751
Merged
zhoxing-ms merged 19 commits intoJan 19, 2023
Conversation
charliedmcb
requested review from
FumingZhang and
andyliuliming
as code owners
added 4 commits
January 12, 2023 12:57
…estrictionLevelToPreviewCLIUpdate+Create
Collaborator
|
AKS |
added 6 commits
January 12, 2023 15:56
FumingZhang
reviewed
Jan 13, 2023
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Queued a live test pipeline to test newly added test case test_aks_create_and_update_with_nrg_restriction_level.
charliedmcb
commented
Jan 17, 2023
charliedmcb
requested review from
FumingZhang
and removed request for
andyliuliming,
yanzhudd and
zhoxing-ms
charliedmcb
commented
Jan 17, 2023
FumingZhang
reviewed
Jan 18, 2023
|
|
||
| @AllowLargeResponse() | ||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus2') | ||
| def test_aks_create_and_update_with_nrg_restriction_level(self, resource_group, resource_group_location): |
added 5 commits
January 18, 2023 12:27
charliedmcb
requested review from
FumingZhang
and removed request for
yanzhudd and
zhoxing-ms
zhoxing-ms
approved these changes
Jan 19, 2023
Collaborator
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=27211&view=results |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.