add --node-os-upgrade-channel to az aks create and az aks update#5788
Merged
wangzelin007 merged 16 commits intoJan 20, 2023
Merged
Conversation
charliedmcb
requested review from
FumingZhang and
andyliuliming
as code owners
ghost
requested review from
ghost
assigned
charliedmcb
commented
Jan 18, 2023
charliedmcb
commented
Jan 18, 2023
added 2 commits
January 18, 2023 14:32
Collaborator
|
aks |
FumingZhang
requested changes
Jan 19, 2023
|
|
||
| @AllowLargeResponse() | ||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus2') | ||
| def test_aks_create_with_node_os_upgrade_channel(self, resource_group, resource_group_location): |
Member
There was a problem hiding this comment.
Queued a pipeline to test these newly added test cases.
|
Add a link to rest api in description. https://github.com/Azure/azure-rest-api-specs/blob/5a4f7662cba770d045d500894a5565c176453cb3/specification/containerservice/resource-manager/Microsoft.ContainerService/preview/2022-11-02-preview/managedClusters.json#L5505 I double checked consts match that |
paulgmiller
reviewed
Jan 19, 2023
paulgmiller
reviewed
Jan 19, 2023
paulgmiller
approved these changes
Jan 19, 2023
paulgmiller
approved these changes
Jan 19, 2023
FumingZhang
reviewed
Jan 20, 2023
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
charliedmcb
requested review from
FumingZhang
and removed request for
andyliuliming,
yanzhudd,
yonzhan and
zhoxing-ms
wangzelin007
approved these changes
Jan 20, 2023
Collaborator
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=27487&view=results |
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.PR description notes
link to rest api:
https://github.com/Azure/azure-rest-api-specs/blob/5a4f7662cba770d045d500894a5565c176453cb3/specification/containerservice/resource-manager/Microsoft.ContainerService/preview/2022-11-02-preview/managedClusters.json#L5505