[AKS] az aks nodepool add/update/upgrade: Add new parameter --drain-timout to slow down the upgrade#27475
Conversation
🔄AzureCLI-FullTest
|
azure-client-tools-bot-prd
Bot
added this to the
October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
❌AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
paulgmiller
changed the title
az aks nodepool add/update/upgreade: Add new parameter --drain-timout to slow down the upgrade
paulgmiller
requested review from
andyliuliming,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
Co-authored-by: Max Horstmann <MaxHorstmann@users.noreply.github.com>
paulgmiller
changed the title
az aks nodepool add/update/upgreade: Add new parameter --drain-timout to slow down the upgradeaz aks nodepool add/update/upgrade: Add new parameter --drain-timout to slow down the upgrade
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM
Please fix the style issues
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/_help.py:1485:92: W291 trailing whitespace
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/_help.py:1485:92: W291 trailing whitespace
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:933:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:1491:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:1754:58: E261 at least two spaces before inline comment
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:1754:59: E262 inline comment should start with '# '
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:1760:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:933:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:1491:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:1754:58: E261 at least two spaces before inline comment
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:1754:59: E262 inline comment should start with '# '
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:1760:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/custom.py:2345:5: E303 too many blank lines (2)
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/custom.py:2345:5: E303 too many blank lines (2)
fixed (forgot style was seperate from lint. miss gofmt) |
@paulgmiller still have some style issues |
Sorry apologize @FumingZhang for the multiple iterations. On my local machine azdev style acs flake8 spits out thosands of errors so have to use the online build to catch these which is slow. All checks are green now. |
|
@zhoxing-ms are you or @yonzhan able to complete this? @FumingZhang is out for a week but already gave his lgtm and max reviewed from aks side and all checks are passing. |
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
| if ( | ||
| self.agentpool and | ||
| self.agentpool.upgrade_settings and | ||
| self.agentpool.upgrade_settings.drain_timeout is not None |
There was a problem hiding this comment.
@paulgmiller @FumingZhang ^^^ shouldn't that be
self.agentpool.upgrade_settings.drain_timeout_in_minutes is not None
?
There was a problem hiding this comment.
Sigh I miss static typing.
7 participants
Related command
az aks nodepool add|update|upgrade
Description
This allows the customer to cofigure time we wait for a node to drain before failing an upgrade operation
This became available in the 07-01 api.
Testing Guide
Same tests as extension create and update with nodeos upgrade channel. Make sure its preserved. Combine with upgrade chennel
History Notes
[AKS]
az aks nodepool add/update/upgrade: Add new parameter--drain-timoutto slow down the upgradeThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.