{AKS} az aks nodepool add/update/upgrade: Add new parameter --node-soak-duration#27604
Merged
yanzhudd merged 106 commits intoJan 26, 2024
Merged
Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
Bot
added this to the
October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
❌AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
FumingZhang,
yanzhudd,
yonzhan and
zhoxing-ms
Collaborator
|
AKS |
microsoft-github-policy-service
Bot
added
Auto-Assign
2 tasks
MaxHorstmann
commented
Oct 17, 2023
yonzhan
modified the milestones:
October 2023 (2023-11-14)❗ Breaking change release ❗,
November 2023 (2023-12-05)
MaxHorstmann
commented
Nov 20, 2023
Collaborator
|
Please fix CI issues. |
…to configure pull image from ACR using MSI when creating a container web app (Azure#28209)
…ons` (Azure#28201) * add metric list by subscription
…d apply `azure-monitor-query` (Azure#28199)
…storage accounts and source file has no parent directory (Azure#28123) * fix `az storage file copy start` with source file with no parent directory * add tests for copy file between different storage accounts, and case when copy from source root directory * remove sas token for credscan
…creating an access policy would delete public access permission (Azure#28211) * fix container policy create where it deletes public access info, still need to fix for share queue table * move container access policy to new file as format is different * fix container set-permission where it would fail with an access policy already set * lint
…meter to ltr policy (Azure#27983) * Adding the make-backups-immutable parameter to ltr policy * Adding the make-backups-immutable parameter to ltr policy
…ce-id` parameter alias `-r` (Azure#28212)
MaxHorstmann
requested review from
DaeunYim,
bebound,
calvinhzy,
digimaun,
evelyn-ys,
jiasli,
kairu-ms,
necusjz,
t-bzhan and
wangzelin007
as code owners
MaxHorstmann
commented
Jan 23, 2024
MaxHorstmann
changed the title
az aks nodepool add/update/upgrade: Add new parameter --node-soak-duration
MaxHorstmann
changed the title
az aks nodepool add/update/upgrade: Add new parameter --node-soak-durationaz aks nodepool add/update/upgrade: Add new parameter --node-soak-duration
FumingZhang
approved these changes
Jan 26, 2024
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM
Queued live test to validate the change. Test passed!
yanzhudd
approved these changes
Jan 26, 2024
yanzhudd
changed the title
az aks nodepool add/update/upgrade: Add new parameter --node-soak-durationaz aks nodepool add/update/upgrade: Add new parameter --node-soak-duration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks nodepool add|update|upgrade
Description
Bringing preview change Azure/azure-cli-extensions#6865 to stable.
Allows customers to specify soak duration for a node during upgrades, i.e. the amount of time (in minutes) to wait after draining a node and before reimaging it and moving on to next node.
This was added to the 2023-11-01 API by Azure/azure-rest-api-specs#26762.
Note that this change is relatively similar to #27475.
Testing Guide
History Notes
[AKS]
az aks nodepool add/update/upgrade: Add new parameter--node-soak-durationto wait after draining a node and before reimaging it and moving on to next nodeThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.