{AKS} aks trustedaccess rolebinding create: Remove --source-resource-id parameter alias -r#28212
Merged
Merged
Conversation
YitongFeng-git
requested review from
andyliuliming,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
Collaborator
|
AKS |
microsoft-github-policy-service
Bot
requested review from
FumingZhang and
yonzhan
microsoft-github-policy-service
Bot
added
Auto-Assign
FumingZhang
reviewed
Jan 18, 2024
| type: string | ||
| short-summary: Specify the comma-separated roles. | ||
| - name: --source-resource-id -r | ||
| - name: --source-resource-id |
Member
There was a problem hiding this comment.
What are the considerations for removing this option?
As this is a breaking change, need to wait until the next breaking change window. Before that, you could mark it as deprecated.
Contributor
Author
There was a problem hiding this comment.
After discussed we decided to remove the alias '-r'.
As TA command hasn't been released ever, we can make this change before this version's release
Member
There was a problem hiding this comment.
The option to be removed was introduced in #27931 on 23/12/22 and released in 2.56.0
karataliu
approved these changes
Jan 18, 2024
FumingZhang
reviewed
Jan 18, 2024
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Queued live test to validate the change.
Member
|
Queued another live test, test passed! |
yanzhudd
approved these changes
Jan 19, 2024
yanzhudd
changed the title
aks trustedaccess rolebinding create: Remove --source-resource-id parameter alias -r
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
…ce-id` parameter alias `-r` (Azure#28212)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks trustedaccess rolebinding createDescription
remove
az aks trustedaccess rolebinding createcommand --source-resource-id parameter alias -rTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.