{AKS} feat: Support trustedaccess role and rolebinding operations#27931
Merged
Conversation
YitongFeng-git
requested review from
andyliuliming,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @YitongFeng-git, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks trustedaccess | sub group aks trustedaccess added |
Collaborator
|
AKS |
microsoft-github-policy-service
Bot
requested review from
FumingZhang and
jiasli
microsoft-github-policy-service
Bot
added
Auto-Assign
YitongFeng-git
changed the title
FumingZhang
reviewed
Nov 28, 2023
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Please add scenario tests for the newly added command/options and adjust PR title/history note according to the guidelines.
e.g.,
- [AKS]
az aks trustedaccess role: Add new command group to manage trusted access roles - [AKS]
az aks trustedaccess rolebinding: Add new command group to manage trusted access role bindings
YitongFeng-git
force-pushed
the
feat/trustedaccess
branch
2 times, most recently
from
76f06ba to
d3dd7b0
Compare
FumingZhang
reviewed
Nov 28, 2023
FumingZhang
reviewed
Nov 28, 2023
YitongFeng-git
force-pushed
the
feat/trustedaccess
branch
6 times, most recently
from
c3c5b43 to
42f19a3
Compare
FumingZhang
approved these changes
Nov 29, 2023
Contributor
Author
|
@zhoxing-ms @yanzhudd could you help review, thanks! |
norshtein
reviewed
Dec 1, 2023
Member
There was a problem hiding this comment.
Only rolebinding is present, should we also add role?
Contributor
Author
There was a problem hiding this comment.
role no need parameter, role only has one command az aks trustedaccess role list, which no need cluster name parameter
YitongFeng-git
force-pushed
the
feat/trustedaccess
branch
from
82c4365 to
2202def
Compare
yanzhudd
reviewed
Dec 18, 2023
yanzhudd
reviewed
Dec 18, 2023
yanzhudd
reviewed
Dec 18, 2023
yanzhudd
reviewed
Dec 18, 2023
Contributor
|
please resolve the conflicts. |
Contributor
Author
|
updated, kindly review again! @yanzhudd help merge this PR to avoid conflicts again, thank you! |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
please resolve CI issues. |
YitongFeng-git
force-pushed
the
feat/trustedaccess
branch
from
1f5edb8 to
c997d7c
Compare
YitongFeng-git
force-pushed
the
feat/trustedaccess
branch
from
28dba17 to
ad073fb
Compare
Contributor
Author
|
@yanzhudd updated! kindly review and merge, thank you ! |
yanzhudd
approved these changes
Dec 22, 2023
yanzhudd
changed the title
Merged
3 tasks
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
TrustedAccess feature GA, move commands from preview to stable
Ref Add roles commands, Add bindings commands
Testing Guide
History Notes
[AKS]
az aks trustedaccess role: Add new command group to manage trusted access roles[AKS]
az aks trustedaccess rolebinding: Add new command group to manage trusted access role bindings[AKS]
az aks trustedaccess rolebinding list: Add new command to list all the trusted access role bindings[AKS]
az aks trustedaccess rolebinding show: Add new command to get the specific trusted access role binding according to binding name[AKS]
az aks trustedaccess rolebinding create: Add new command to create a new trusted access role binding[AKS]
az aks trustedaccess rolebinding update: Add new command to update an existing trusted access role binding[AKS]
az aks trustedaccess rolebinding delete: Add new command to delete a trusted access role binding according to nameThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.