[AKS] az aks create/update: Add new parameter --node-os-upgrade-channel to specify which OS on your nodes is updated#27167
Merged
Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter node_os_upgrade_channel |
||
| aks update | cmd aks update added parameter node_os_upgrade_channel |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
paulgmiller
requested review from
andyliuliming,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
paulgmiller
changed the title
Contributor
Author
|
@wangzelin007 and @FumingZhang would you mind looking at this sicne you approved Azure/azure-cli-extensions#5788 it should be a mirror of that. Also we can remove code from preview extension after this is live. Since this gives customers a way to disable Unattended Upgrades (which caused a sev 1 across several regions on saturday we might actually ask for an expidtited release of this) |
paulgmiller
changed the title
az aks create|update: allow use of --node-os-upgade channel
paulgmiller
changed the title
az aks create|update: allow use of --node-os-upgade channelaz aks create|update: Allow use of --node-os-uprgade channel
paulgmiller
force-pushed
the
pmiller/nodeosupgradechannel
branch
from
2a83a2e to
096d578
Compare
FumingZhang
reviewed
Aug 15, 2023
zhoxing-ms
changed the title
az aks create|update: Allow use of --node-os-uprgade channelaz aks create/update: Allow use of --node-os-uprgade channel
zhoxing-ms
changed the title
az aks create/update: Allow use of --node-os-uprgade channelaz aks create/update: Allow use of --node-os-uprgade channel
zhoxing-ms
changed the title
az aks create/update: Allow use of --node-os-uprgade channelaz aks create/update: Add new parameter --node-os-upgrade-channel to specify which OS on your nodes is updated
…com/Azure/azure-cli-extensions/pull/5788/files update linter revert history try and clean up whitespace bad whitespace security pathc is not ga yet
paulgmiller
force-pushed
the
pmiller/nodeosupgradechannel
branch
from
096d578 to
dedc457
Compare
paulgmiller
force-pushed
the
pmiller/nodeosupgradechannel
branch
from
dedc457 to
0637eb4
Compare
Contributor
Author
|
@zhoxing-ms anythign else you need here? |
zhoxing-ms
approved these changes
Aug 17, 2023
paulgmiller
pushed a commit
to paulgmiller/azure-cli
that referenced
this pull request
Aug 29, 2023
…annel` to specify which OS on your nodes is updated (Azure#27167)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…com/Azure/azure-cli-extensions/pull/5788/files
Related command
az aks create|update
Description
This allows the setting of node os upgrade channel in create and update of aks clusters.
Public docs are here. https://learn.microsoft.com/en-us/azure/aks/auto-upgrade-node-image
It is GAing this preview extension: Azure/azure-cli-extensions#5788
This became available in the 06-01 api.
Testing Guide
Same tests as extension create and update with nodeos upgrade channel. Make sure its preserved. Combine with upgrade chennel
History Notes
[AKS]
az aks create/update: Add new parameter--node-os-upgrade-channelto specify which OS on your nodes is updatedThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.