{CI} Optimize the extension test: Use azdev test for testing, consistent with the main repo#5925
Merged
Merged
Conversation
azdev test for testing, consistent with the main repo
bebound
approved these changes
Feb 24, 2023
Collaborator
|
CI |
jiasli
reviewed
Feb 24, 2023
| f'ALL_TESTS: {ALL_TESTS}.') | ||
|
|
||
|
|
||
| class TestExtensionSourceMeta(type): |
Member
There was a problem hiding this comment.
The intention of this metaclass is to add test methods to TestExtensionSource during the initialization of TestExtensionSource.
To verify that, we can add print(TestExtensionSource.__dict__.keys()) to L97 and check the output:
dict_keys(['__module__', 'setUp', 'tearDown', 'test_azext_account', 'test_azext_acrtransfer', 'test_azext_ad', 'test_azext_adp', 'test_azext_aem', 'test_azext_ai_examples', 'test_azext_aks_preview', 'test_azext_alertsmanagement',
It generates a bunch of methods starting with test_ for each extension so that unittest can run them one by one.
Question is: what is the point of it, when it can simply be replaced by a for loop and invoke unittest or pytest on one extension in each iteration?
jiasli
reviewed
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old test uses python unittest, and the test log is as follows:


The new test uses azdev test, and the test log is as follows: