Adding the cli command option for --pod-ip-allocation-mode for cluster creation and nodepool addition in AKS by nairashu · Pull Request #7288 · Azure/azure-cli-extensions

Adding the cli command option for --pod-ip-allocation-mode

Ashish Nair

committed

Added all the fields to read and populate the pod ip allocation mode from the az aks create and az aks nodepool commands with validations

Ashish Nair

committed

Addressed all the code review comments by removing the Unassigned from the CLI, use the raw_param as the source of truth else fallback on agentpool config

Ashish Nair

committed

Added a UT for the new podIPAllocationProperty

Ashish Nair

committed

Added the new UT to be called on the required decorators

Ashish Nair

committed

Added a live test case for podIPAllocationMode and creating a StaticBlock cluster

Ashish Nair

committed

Added the necessary space

Ashish Nair

committed

Simplified the logic to read from the agentpool profile if the value exists else deafault to the value provided by the user in the command line

Ashish Nair

committed

Trying to fix the linter issues

Ashish Nair

committed

Updated the code to adhere to the azdev styles

Ashish Nair

committed

Fixed errors to adhere to the azdev styles

Ashish Nair

committed

Attempting to not initialize any pod-ip-allocation-mode by default and then attach an agentpool with StaticBlock

Ashish Nair

committed

Fixed param list

Ashish Nair

committed

Adding the live only tag for the live test added

Ashish Nair

committed

Fixed the missing '-' from the max-pods argument

Ashish Nair

committed

Attempting to fix the resource ID for the node subnet

Ashish Nair

committed

Attempting to fix the resource ID for the node subnet

Ashish Nair

committed

Fixed the property name of the agentpoolprofile

Ashish Nair

committed

Updated the expected value for podSubnetID

Ashish Nair

committed

Added the logic to add the podIPAllocationMode to the agentpool network profile which was what was failing the CI

Ashish Nair

committed

Removed the reference to agentpool network profile

Ashish Nair

committed

Added a test case for managed_cluster properties generation

Ashish Nair

committed

Added methods to update the pod ip allocation mode property of the agentpool to both the create and update methods

Ashish Nair

committed

Fixing the variable name in the live test aks_name

Ashish Nair

committed

Added the live test recording to the PR

Ashish Nair

committed

Updated the PR based on the review comments to reorder the logic in the get method for the pod-ip-allocation-mode property and also removed the definition and call to set the property in the AgentP…

Ashish Nair

committed

Updated the test cases based on the suggestions made in the PR review

Ashish Nair

committed

Upated the History and setup.py files after rebasing to merge the new property in the next version

Ashish Nair

committed

Fixed the assertion value

Ashish Nair

committed

Fixed the azdev styles issue

Ashish Nair

committed

Removed the liveonly tag

Ashish Nair

committed

Excluding the test from the live test as it requires feature registration

Ashish Nair

committed

Update src/aks-preview/azext_aks_preview/_help.py based on the suggested change

nairashu

and

zhoxing-ms

authored

Update src/aks-preview/azext_aks_preview/_help.py to use first-person voice.

nairashu

and

zhoxing-ms

authored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding the cli command option for --pod-ip-allocation-mode for cluster creation and nodepool addition in AKS#7288

Adding the cli command option for --pod-ip-allocation-mode for cluster creation and nodepool addition in AKS#7288
wangzelin007 merged 34 commits into
Azure:mainfrom
nairashu:asn/VScale/CliChanges

Commits on Feb 29, 2024

Adding the cli command option for --pod-ip-allocation-mode

Added all the fields to read and populate the pod ip allocation mode from the az aks create and az aks nodepool commands with validations

Addressed all the code review comments by removing the Unassigned from the CLI, use the raw_param as the source of truth else fallback on agentpool config

Added a UT for the new podIPAllocationProperty

Added the new UT to be called on the required decorators

Added a live test case for podIPAllocationMode and creating a StaticBlock cluster

Added the necessary space

Simplified the logic to read from the agentpool profile if the value exists else deafault to the value provided by the user in the command line

Trying to fix the linter issues

Updated the code to adhere to the azdev styles

Fixed errors to adhere to the azdev styles

Attempting to not initialize any pod-ip-allocation-mode by default and then attach an agentpool with StaticBlock

Fixed param list

Adding the live only tag for the live test added

Fixed the missing '-' from the max-pods argument

Attempting to fix the resource ID for the node subnet

Attempting to fix the resource ID for the node subnet

Fixed the property name of the agentpoolprofile

Updated the expected value for podSubnetID

Added the logic to add the podIPAllocationMode to the agentpool network profile which was what was failing the CI

Removed the reference to agentpool network profile

Added a test case for managed_cluster properties generation

Added methods to update the pod ip allocation mode property of the agentpool to both the create and update methods

Fixing the variable name in the live test aks_name

Added the live test recording to the PR

Updated the PR based on the review comments to reorder the logic in the get method for the pod-ip-allocation-mode property and also removed the definition and call to set the property in the AgentP…

Updated the test cases based on the suggestions made in the PR review

Upated the History and setup.py files after rebasing to merge the new property in the next version

Fixed the assertion value

Fixed the azdev styles issue

Removed the liveonly tag

Excluding the test from the live test as it requires feature registration

Update src/aks-preview/azext_aks_preview/_help.py based on the suggested change

Update src/aks-preview/azext_aks_preview/_help.py to use first-person voice.