-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Adding the cli command option for --pod-ip-allocation-mode for cluster creation and nodepool addition in AKS #7288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
6a45326
Adding the cli command option for --pod-ip-allocation-mode
4d3522b
Added all the fields to read and populate the pod ip allocation mode …
b2ada0b
Addressed all the code review comments by removing the Unassigned fro…
7aed936
Added a UT for the new podIPAllocationProperty
cf31fda
Added the new UT to be called on the required decorators
6557fd0
Added a live test case for podIPAllocationMode and creating a StaticB…
2272726
Added the necessary space
e1580d3
Simplified the logic to read from the agentpool profile if the value …
9ed4b7d
Trying to fix the linter issues
b4a113d
Updated the code to adhere to the azdev styles
fde8789
Fixed errors to adhere to the azdev styles
4516aaa
Attempting to not initialize any pod-ip-allocation-mode by default an…
da0e473
Fixed param list
4d6de3f
Adding the live only tag for the live test added
6882dfd
Fixed the missing '-' from the max-pods argument
3ad89a1
Attempting to fix the resource ID for the node subnet
24a52a2
Attempting to fix the resource ID for the node subnet
5953766
Fixed the property name of the agentpoolprofile
4cad504
Updated the expected value for podSubnetID
88ff1e1
Added the logic to add the podIPAllocationMode to the agentpool netwo…
0c1276b
Removed the reference to agentpool network profile
256a1bf
Added a test case for managed_cluster properties generation
83bc419
Added methods to update the pod ip allocation mode property of the ag…
15ebd05
Fixing the variable name in the live test aks_name
3035ee2
Added the live test recording to the PR
5bbc405
Updated the PR based on the review comments to reorder the logic in t…
c587768
Updated the test cases based on the suggestions made in the PR review
30feb66
Upated the History and setup.py files after rebasing to merge the new…
c50184d
Fixed the assertion value
3572460
Fixed the azdev styles issue
b1e48ee
Removed the liveonly tag
d519a51
Excluding the test from the live test as it requires feature registra…
1703660
Update src/aks-preview/azext_aks_preview/_help.py based on the sugges…
nairashu 39ad6cb
Update src/aks-preview/azext_aks_preview/_help.py to use first-person…
nairashu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.