Skip to content

aksarc 0.2.0b1 VMware support release#7409

Closed
TheOnlyWei wants to merge 1 commit into
Azure:mainfrom
TheOnlyWei:aksarc-0.2.0b1-release
Closed

aksarc 0.2.0b1 VMware support release#7409
TheOnlyWei wants to merge 1 commit into
Azure:mainfrom
TheOnlyWei:aksarc-0.2.0b1-release

Conversation

@TheOnlyWei
Copy link
Copy Markdown
Contributor

@TheOnlyWei TheOnlyWei commented Mar 22, 2024

Related command

az aksarc
https://learn.microsoft.com/en-us/cli/azure/aksarc?view=azure-cli-latest

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
    Note: azdev style <YOUR_EXT> is not enforced currently for our extension in our private repository.
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

About Extension Publish

Note that we are releasing an extension from a private repository and need to manually update the src/index.json!

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Mar 22, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @TheOnlyWei,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 22, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@TheOnlyWei
Copy link
Copy Markdown
Contributor Author

TheOnlyWei commented Mar 22, 2024

Verify Extensions Index pipeline failed due to someone else's extension called spring-1.20.1-py3-none-any.whl. It should be good to merge.

@wangzelin007
Copy link
Copy Markdown
Member

Verify Extensions Index pipeline failed due to someone else's extension called spring-1.20.1-py3-none-any.whl. It should be good to merge.

It will be fixed by this PR

Comment thread src/index.json
}
],
"aksarc": [
{
Copy link
Copy Markdown
Member

@jsntcy jsntcy Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We suggest you change the version to 1.0.0b1 (preview) or 1.0.0 (stable) as now CLI extension version should conform to the Extension version schema

Copy link
Copy Markdown
Contributor Author

@TheOnlyWei TheOnlyWei Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this? We are releasing an older version of our extension. Are you saying the minimum version has to be 1.0.0? If so, should be added to the doc to clarify since I already read that doc.

To clarify, several places reference possibility of have lower than version 1.0.0. E.g., this statement implies versions can be less than 1.0.0:

If last version is less than 1.0.0, then, the next preview version should be 1.0.0b1 and the next stable one should be 1.0.0

That should really say "Minimum preview version is 1.0.0b1 and minimum stable version is 1.0.0". I read that sentence as implying that you can have a released version less than 1.0.0, i.e., you can have a release version of something like 0.2.0b1.

@wangzelin007
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@TheOnlyWei TheOnlyWei changed the title aksarc 0.2.0b1 VMware support release aksarc 1.0.0b1 VMware support release Mar 26, 2024
@TheOnlyWei TheOnlyWei changed the title aksarc 1.0.0b1 VMware support release aksarc 0.2.0b1 VMware support release Mar 26, 2024
@TheOnlyWei
Copy link
Copy Markdown
Contributor Author

Closing this in favor of this updated PR:
#7416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants