Skip to content

aksarc 1.0.0b1 VMware support release#7416

Merged
jsntcy merged 1 commit into
Azure:mainfrom
TheOnlyWei:aksarc-1.0.0b1-release
Mar 27, 2024
Merged

aksarc 1.0.0b1 VMware support release#7416
jsntcy merged 1 commit into
Azure:mainfrom
TheOnlyWei:aksarc-1.0.0b1-release

Conversation

@TheOnlyWei
Copy link
Copy Markdown
Contributor

@TheOnlyWei TheOnlyWei commented Mar 26, 2024

Related command

az aksarc
https://learn.microsoft.com/en-us/cli/azure/aksarc?view=azure-cli-latest

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
    Note: azdev style <YOUR_EXT> is not enforced currently for our extension in our private repository.
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

About Extension Publish

Note that we are releasing an extension from a private repository and need to manually update the src/index.json!

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Mar 26, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @TheOnlyWei,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @TheOnlyWei,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 26, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Copy Markdown
Member

@jsntcy jsntcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version looks weird as the extension has already been released with version 1.0.0, 1.0.2, .....1.1.1, usually the next version should be larger than 1.1.1.

image

@TheOnlyWei
Copy link
Copy Markdown
Contributor Author

TheOnlyWei commented Mar 26, 2024

@jsntcy as mentioned in previous PR, we are trying to release an older version. Do you want us to change the version again? You said it should be 1.0.0 or 1.0.0b1. Our product is a special case currently, because our main branch, which are the stable releases, doesn't support the platform which our 1.0.0b1 release supports, and vice versa, the code in the specific release of our 1.0.0b1 extension doesn't have certain features that the stable release supports. So, we are kind of forced to release via an older version to preserve customer experience.

#7409 (comment)

@jsntcy
Copy link
Copy Markdown
Member

jsntcy commented Mar 26, 2024

@jsntcy as mentioned in previous PR, we are trying to release an older version. Do you want us to change the version again? You said it should be 1.0.0 or 1.0.0b1. Our product is a special case currently, because our main branch, which are the stable releases, doesn't support the platform which our 1.0.0b1 release supports, and vice versa, the code in the specific release of our 1.0.0b1 extension doesn't have certain features that the stable release supports. So, we are kind of forced to release via an older version to preserve customer experience.

#7409 (comment)

As your source code is not in our extension repo, so it's a little difficult for us to know which versions you have released. In this review, we expanded and scrolled down the long index.json file and found you have already released 1.0.0, 1.0.2, .....1.1.1 before. But in last review #7409 (comment), you released as 0.2.0b1, as a common sense of versioning, we supposed you never released version 1.x.x before as we never release a new version with smaller number than before.

As your code is not in our repo, it's difficult for us to suggest a specific version for you as we don't know if the new version has breaking changes or not (or release it as preview or stable) , but we can suggest some versions per different scenarios:

  • If this new version has breaking changes, suggest to release it as 2.0.0b1 (preview), or 2.0.0 (stable)
  • If this new version has no breaking changes, suggest to release it as 1.2.0b1 (preview), or 1.2.0 (stable)
  • If this new version is just a bug fix, suggest to release it as 1.1.2b1 (preview), or 1.1.2 (stable)

Actually based on our Extension version schema, you can figure out the version yourself as well.

BTW, if possible, we suggest you move your source code to our extension repo, so that you can leverage our CI/CD including breaking change detection, version suggestion and etc.

@jsntcy jsntcy merged commit 12bdeee into Azure:main Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants